linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@dilger.ca>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>
Subject: [PATCH] tests: skip large filesystem tests on MacOS
Date: Fri, 22 May 2015 16:39:18 -0600	[thread overview]
Message-ID: <1432334358-6035-1-git-send-email-adilger@dilger.ca> (raw)

Skip tests that create large filesystem on MacOS, since HFS doesn't
have sparse file support and this causes testing to be uninterruptible
for minutes while mke2fs is writing to some large non-zero offset and
filling up the test filesystem.  Since most testing is done on Linux
this shouldn't cause a significant gap in testing coverage.

Tests skipped are d_dumpe2fs_group_only, m_bigjournal, m_hugefile,
t_iexpand_full, t_iexpand_mcsum, and t_uninit_bg_rm.

Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
 tests/d_dumpe2fs_group_only/script |    6 ++++++
 tests/m_bigjournal/script          |    1 +
 tests/m_hugefile/script            |    6 ++++++
 tests/t_iexpand_full/script        |    6 ++++++
 tests/t_iexpand_mcsum/script       |    5 +++++
 tests/t_uninit_bg_rm/script        |    6 ++++++
 6 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/tests/d_dumpe2fs_group_only/script b/tests/d_dumpe2fs_group_only/script
index 127502f..50481f0 100644
--- a/tests/d_dumpe2fs_group_only/script
+++ b/tests/d_dumpe2fs_group_only/script
@@ -1,3 +1,9 @@
+if [ $(uname -s) = "Darwin" ]; then
+	# creates a 4GB filesystem
+	echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
+	return 0
+fi
+
 if test -x $DEBUGFS_EXE; then
 
 FSCK_OPT=-fy
diff --git a/tests/m_bigjournal/script b/tests/m_bigjournal/script
index 576d99e..96ea082 100644
--- a/tests/m_bigjournal/script
+++ b/tests/m_bigjournal/script
@@ -4,6 +4,7 @@ DUMPE2FS_IGNORE_80COL=1
 export DUMPE2FS_IGNORE_80COL
 MKE2FS_OPTS="-t ext4 -G 512 -N 1280 -J size=5000 -q -E lazy_journal_init,lazy_itable_init,nodiscard"
 if [ $(uname -s) = "Darwin" ]; then
+	# creates a 44GB filesystem
 	echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
 	return 0
 fi
diff --git a/tests/m_hugefile/script b/tests/m_hugefile/script
index 72af8b8..5619f64 100644
--- a/tests/m_hugefile/script
+++ b/tests/m_hugefile/script
@@ -3,6 +3,12 @@ OUT=$test_name.log
 EXP=$test_dir/expect
 CONF=$TMPFILE.conf
 
+if [ $(uname -s) = "Darwin" ]; then
+	# creates a 4TB filesystem
+	echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
+	return 0
+fi
+
 #gzip -d < $EXP.gz > $EXP
 
 cat > $CONF << ENDL
diff --git a/tests/t_iexpand_full/script b/tests/t_iexpand_full/script
index 779c66d..f8565a7 100644
--- a/tests/t_iexpand_full/script
+++ b/tests/t_iexpand_full/script
@@ -1,5 +1,11 @@
 if test -x $RESIZE2FS_EXE -a -x $DEBUGFS_EXE; then
 
+if [ $(uname -s) = "Darwin" ]; then
+	# creates a 3GB filesystem
+	echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
+	return 0
+fi
+
 FSCK_OPT=-fn
 OUT=$test_name.log
 EXP=$test_dir/expect
diff --git a/tests/t_iexpand_mcsum/script b/tests/t_iexpand_mcsum/script
index 3057dba..4b584d3 100644
--- a/tests/t_iexpand_mcsum/script
+++ b/tests/t_iexpand_mcsum/script
@@ -1,4 +1,9 @@
 if test -x $RESIZE2FS_EXE -a -x $DEBUGFS_EXE; then
+if [ $(uname -s) = "Darwin" ]; then
+	# creates a 3GB filesystem
+	echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
+	return 0
+fi
 
 FSCK_OPT=-fn
 OUT=$test_name.log
diff --git a/tests/t_uninit_bg_rm/script b/tests/t_uninit_bg_rm/script
index cd397c5..308ef25 100644
--- a/tests/t_uninit_bg_rm/script
+++ b/tests/t_uninit_bg_rm/script
@@ -3,6 +3,12 @@ OUT=$test_name.log
 FSCK_OPT=-yf
 EXP=$test_dir/expect
 
+if [ $(uname -s) = "Darwin" ]; then
+	# creates a 10GB filesystem
+	echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
+	return 0
+fi
+
 cp /dev/null $TMPFILE
 rm -f $OUT.new
 
-- 
1.7.3.4


             reply	other threads:[~2015-05-22 22:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 22:39 Andreas Dilger [this message]
2015-05-22 22:45 ` [PATCH] tests: skip large filesystem tests on MacOS Andreas Dilger
2015-06-20  1:31 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432334358-6035-1-git-send-email-adilger@dilger.ca \
    --to=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).