Re: [PATCH 4/8] ext4 crypto: encrypt tmpfile located in encryption protected directory

Theodore Ts'o
2015-05-29T16:33:34Z

On Fri, May 29, 2015 at 08:09:01AM -0300, Albino Biasutti Neto wrote:
> 2015-05-28 20:47 GMT-03:00 Theodore Ts'o <tytso@mit.edu>:
> > +static inline struct ext4_crypt_info *ext4_encryption_info(struct inode *inode)
> > +{
> > + return NULL;
> > +}
> > #endif
>
> Ts´o, this code can not return anything be empty or not ?

I'm not sure what you ar asking, since I can't quite parse your
question as a valid english sentence, sorry.

I think what you are asking is why is this function always returning
NULL?

That's because it's in the #else clause of an #ifdef
CONFIG_EXT4_FS_ENCRYPTION. In the case where
CONFIG_EXT4_FS_ENCRYPTION is defined, it returns:

static inline struct ext4_crypt_info *ext4_encryption_info(struct inode *inode)
{
return EXT4_I(inode)->i_crypt_info;
}

The idea is to minimize the need for #ifdef's in the .c files.

Regards,

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html