From: Joe Perches <joe@perches.com>
To: Laurent Navet <laurent.navet@gmail.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4 crypto: remove unneeded assignation
Date: Wed, 08 Jul 2015 12:55:39 -0700 [thread overview]
Message-ID: <1436385339.2682.93.camel@perches.com> (raw)
In-Reply-To: <1436385075-22559-1-git-send-email-laurent.navet@gmail.com>
On Wed, 2015-07-08 at 21:51 +0200, Laurent Navet wrote:
> Return value of ext4_derive_key_aes() is stored but never used before
> being overwritten.
> Also fix coverity CID 1309760.
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> fs/ext4/crypto_key.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c
> index 442d24e..92f9172 100644
> --- a/fs/ext4/crypto_key.c
> +++ b/fs/ext4/crypto_key.c
> @@ -218,7 +218,7 @@ retry:
> BUILD_BUG_ON(EXT4_AES_128_ECB_KEY_SIZE !=
> EXT4_KEY_DERIVATION_NONCE_SIZE);
> BUG_ON(master_key->size != EXT4_AES_256_XTS_KEY_SIZE);
> - res = ext4_derive_key_aes(ctx.nonce, master_key->raw,
> + ext4_derive_key_aes(ctx.nonce, master_key->raw,
> raw_key);
More likely this should be:
res = ext4_derive_key_aes(,,,);
if (res)
goto out;
> got_key:
> ctfm = crypto_alloc_ablkcipher(cipher_str, 0, 0);
next prev parent reply other threads:[~2015-07-08 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 19:51 [PATCH] ext4 crypto: remove unneeded assignation Laurent Navet
2015-07-08 19:55 ` Joe Perches [this message]
2015-07-08 20:01 ` Darrick J. Wong
2015-07-09 19:04 ` Laurent Navet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436385339.2682.93.camel@perches.com \
--to=joe@perches.com \
--cc=adilger.kernel@dilger.ca \
--cc=laurent.navet@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox