* [RFC][PATCH 3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa [not found] <1442279124-7309-1-git-send-email-john.stultz@linaro.org> @ 2015-09-15 1:05 ` John Stultz 2015-10-19 4:03 ` [RFC,3/5] " Theodore Ts'o 0 siblings, 1 reply; 2+ messages in thread From: John Stultz @ 2015-09-15 1:05 UTC (permalink / raw) To: LKML Cc: John Stultz, Theodore Ts'o, Andreas Dilger, Ingo Molnar, linux-ext4 The ext4_fsblk_t type is a long long, which should not be used with abs(), as is done in ext4_mb_check_group_pa(). This patch modifies ext4_mb_check_group_pa() to use abs64() instead. Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Andreas Dilger <adilger.kernel@dilger.ca> Cc: Ingo Molnar <mingo@kernel.org> Cc: linux-ext4@vger.kernel.org Signed-off-by: John Stultz <john.stultz@linaro.org> --- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 34b610e..4780ab1 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3331,8 +3331,8 @@ ext4_mb_check_group_pa(ext4_fsblk_t goal_block, atomic_inc(&pa->pa_count); return pa; } - cur_distance = abs(goal_block - cpa->pa_pstart); - new_distance = abs(goal_block - pa->pa_pstart); + cur_distance = abs64(goal_block - cpa->pa_pstart); + new_distance = abs64(goal_block - pa->pa_pstart); if (cur_distance <= new_distance) return cpa; -- 1.9.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC,3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa 2015-09-15 1:05 ` [RFC][PATCH 3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa John Stultz @ 2015-10-19 4:03 ` Theodore Ts'o 0 siblings, 0 replies; 2+ messages in thread From: Theodore Ts'o @ 2015-10-19 4:03 UTC (permalink / raw) To: John Stultz; +Cc: linux-ext4 On Mon, Sep 14, 2015 at 06:05:22PM -0700, John Stultz wrote: > The ext4_fsblk_t type is a long long, which should not be used > with abs(), as is done in ext4_mb_check_group_pa(). > > This patch modifies ext4_mb_check_group_pa() to use abs64() > instead. > > Cc: "Theodore Ts'o" <tytso@mit.edu> > Cc: Andreas Dilger <adilger.kernel@dilger.ca> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: linux-ext4@vger.kernel.org > Signed-off-by: John Stultz <john.stultz@linaro.org> Applied, thanks. - Ted ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-19 4:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1442279124-7309-1-git-send-email-john.stultz@linaro.org>
2015-09-15 1:05 ` [RFC][PATCH 3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa John Stultz
2015-10-19 4:03 ` [RFC,3/5] " Theodore Ts'o
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).