From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Turner <novalis@novalis.org>
Subject: Re: [PATCH] e2fsck: Correct ext4 dates generated by old kernels
Date: Wed, 25 Nov 2015 01:01:35 -0500
Message-ID: <1448431295.7696.9.camel@novalis.org>
References: <1448400852-90545-1-git-send-email-adilger@dilger.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: linux-ext4@vger.kernel.org
To: Andreas Dilger <adilger@dilger.ca>, tytso@mit.edu
Return-path: <linux-ext4-owner@vger.kernel.org>
Received: from hapkido.dreamhost.com ([66.33.216.122]:39971 "EHLO
	hapkido.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751182AbbKYGBh (ORCPT
	<rfc822;linux-ext4@vger.kernel.org>); Wed, 25 Nov 2015 01:01:37 -0500
Received: from homiemail-a23.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7])
	by hapkido.dreamhost.com (Postfix) with ESMTP id 6940489B5B
	for <linux-ext4@vger.kernel.org>; Tue, 24 Nov 2015 22:01:37 -0800 (PST)
In-Reply-To: <1448400852-90545-1-git-send-email-adilger@dilger.ca>
Sender: linux-ext4-owner@vger.kernel.org
List-ID: <linux-ext4.vger.kernel.org>

On Tue, 2015-11-24 at 14:34 -0700, Andreas Dilger wrote: 
> +static int check_inode_extra_negative_epoch(__u32 xtime, __u32
> extra) {
> +	return (xtime & (1 << 31)) != 0 &&

On a re-read, I think the bitshift is technically undefined behavior
because 1 is signed and 2**31 is not representable as a signed (32-bit)
int. Changing it to 1U should fix it.

Other than that, LGTM.