From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Theodore Ts'o <tytso@mit.edu>,
Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix an endianness bug in ext4_encrypted_follow_link()
Date: Thu, 26 Nov 2015 11:40:37 -0800 [thread overview]
Message-ID: <1448566837.18647.16.camel@perches.com> (raw)
In-Reply-To: <20151126152728.GT22011@ZenIV.linux.org.uk>
(cc'ing Julia Lawall)
On Thu, 2015-11-26 at 15:27 +0000, Al Viro wrote:
> applying le32_to_cpu() to 16bit value is a bad idea...
Julia, perhaps you or your crew could produce a coccinelle test
for this class of error?
> diff --git a/fs/ext4/symlink.c b/fs/ext4/symlink.c
> index abe2401..e8e7af6 100644
> --- a/fs/ext4/symlink.c
> +++ b/fs/ext4/symlink.c
> @@ -52,7 +52,7 @@ static const char *ext4_encrypted_follow_link(struct dentry *dentry, void **cook
> /* Symlink is encrypted */
> sd = (struct ext4_encrypted_symlink_data *)caddr;
> cstr.name = sd->encrypted_path;
> - cstr.len = le32_to_cpu(sd->len);
> + cstr.len = le16_to_cpu(sd->len);
> if ((cstr.len +
> sizeof(struct ext4_encrypted_symlink_data) - 1) >
> max_size) {
next prev parent reply other threads:[~2015-11-26 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 15:27 [PATCH] fix an endianness bug in ext4_encrypted_follow_link() Al Viro
2015-11-26 19:40 ` Joe Perches [this message]
2015-11-26 21:02 ` Al Viro
2015-11-26 21:28 ` Julia Lawall
2015-11-26 22:47 ` Joe Perches
2015-11-27 1:31 ` Fengguang Wu
2015-11-26 20:22 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448566837.18647.16.camel@perches.com \
--to=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).