* [PATCH] e2fsprogs: fix flag settings in e2image.h
@ 2013-02-21 12:06 Tomas Racek
2013-02-21 13:00 ` Lukáš Czerner
2013-04-22 3:49 ` Theodore Ts'o
0 siblings, 2 replies; 4+ messages in thread
From: Tomas Racek @ 2013-02-21 12:06 UTC (permalink / raw)
To: linux-ext4; +Cc: Tomas Racek
This prevents from SIGSEGV when -s options is used.
Signed-off-by: Tomas Racek <tracek@redhat.com>
---
lib/ext2fs/e2image.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ext2fs/e2image.h b/lib/ext2fs/e2image.h
index c918529..5537980 100644
--- a/lib/ext2fs/e2image.h
+++ b/lib/ext2fs/e2image.h
@@ -19,7 +19,7 @@
/* Image flags */
#define E2IMAGE_INSTALL_FLAG 1
#define E2IMAGE_SCRAMBLE_FLAG 2
-#define E2IMAGE_IS_QCOW2_FLAG 3
+#define E2IMAGE_IS_QCOW2_FLAG 4
struct ext2_image_hdr {
__u32 magic_number; /* This must be EXT2_ET_MAGIC_E2IMAGE */
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] e2fsprogs: fix flag settings in e2image.h
2013-02-21 12:06 [PATCH] e2fsprogs: fix flag settings in e2image.h Tomas Racek
@ 2013-02-21 13:00 ` Lukáš Czerner
2013-02-28 20:11 ` Tomas Racek
2013-04-22 3:49 ` Theodore Ts'o
1 sibling, 1 reply; 4+ messages in thread
From: Lukáš Czerner @ 2013-02-21 13:00 UTC (permalink / raw)
To: Tomas Racek; +Cc: linux-ext4
On Thu, 21 Feb 2013, Tomas Racek wrote:
> Date: Thu, 21 Feb 2013 13:06:58 +0100
> From: Tomas Racek <tracek@redhat.com>
> To: linux-ext4@vger.kernel.org
> Cc: Tomas Racek <tracek@redhat.com>
> Subject: [PATCH] e2fsprogs: fix flag settings in e2image.h
>
> This prevents from SIGSEGV when -s options is used.
oops! Thanks for catching that. I just wonder why the regression
test is not catching that ?
you can add
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> Signed-off-by: Tomas Racek <tracek@redhat.com>
> ---
> lib/ext2fs/e2image.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ext2fs/e2image.h b/lib/ext2fs/e2image.h
> index c918529..5537980 100644
> --- a/lib/ext2fs/e2image.h
> +++ b/lib/ext2fs/e2image.h
> @@ -19,7 +19,7 @@
> /* Image flags */
> #define E2IMAGE_INSTALL_FLAG 1
> #define E2IMAGE_SCRAMBLE_FLAG 2
> -#define E2IMAGE_IS_QCOW2_FLAG 3
> +#define E2IMAGE_IS_QCOW2_FLAG 4
>
> struct ext2_image_hdr {
> __u32 magic_number; /* This must be EXT2_ET_MAGIC_E2IMAGE */
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] e2fsprogs: fix flag settings in e2image.h
2013-02-21 13:00 ` Lukáš Czerner
@ 2013-02-28 20:11 ` Tomas Racek
0 siblings, 0 replies; 4+ messages in thread
From: Tomas Racek @ 2013-02-28 20:11 UTC (permalink / raw)
To: Lukáš Czerner; +Cc: linux-ext4
----- Original Message -----
> On Thu, 21 Feb 2013, Tomas Racek wrote:
>
> > Date: Thu, 21 Feb 2013 13:06:58 +0100
> > From: Tomas Racek <tracek@redhat.com>
> > To: linux-ext4@vger.kernel.org
> > Cc: Tomas Racek <tracek@redhat.com>
> > Subject: [PATCH] e2fsprogs: fix flag settings in e2image.h
> >
> > This prevents from SIGSEGV when -s options is used.
>
> oops! Thanks for catching that. I just wonder why the regression
> test is not catching that ?
Well, it seems that "-s" option is not tested (or even used). I'll try to fix at least the first thing. ;-)
Tom
>
>
> you can add
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> >
> > Signed-off-by: Tomas Racek <tracek@redhat.com>
> > ---
> > lib/ext2fs/e2image.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/ext2fs/e2image.h b/lib/ext2fs/e2image.h
> > index c918529..5537980 100644
> > --- a/lib/ext2fs/e2image.h
> > +++ b/lib/ext2fs/e2image.h
> > @@ -19,7 +19,7 @@
> > /* Image flags */
> > #define E2IMAGE_INSTALL_FLAG 1
> > #define E2IMAGE_SCRAMBLE_FLAG 2
> > -#define E2IMAGE_IS_QCOW2_FLAG 3
> > +#define E2IMAGE_IS_QCOW2_FLAG 4
> >
> > struct ext2_image_hdr {
> > __u32 magic_number; /* This must be EXT2_ET_MAGIC_E2IMAGE */
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] e2fsprogs: fix flag settings in e2image.h
2013-02-21 12:06 [PATCH] e2fsprogs: fix flag settings in e2image.h Tomas Racek
2013-02-21 13:00 ` Lukáš Czerner
@ 2013-04-22 3:49 ` Theodore Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2013-04-22 3:49 UTC (permalink / raw)
To: Tomas Racek; +Cc: linux-ext4
On Thu, Feb 21, 2013 at 01:06:58PM +0100, Tomas Racek wrote:
> This prevents from SIGSEGV when -s options is used.
>
> Signed-off-by: Tomas Racek <tracek@redhat.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-22 3:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-21 12:06 [PATCH] e2fsprogs: fix flag settings in e2image.h Tomas Racek
2013-02-21 13:00 ` Lukáš Czerner
2013-02-28 20:11 ` Tomas Racek
2013-04-22 3:49 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).