linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pranay Kr. Srivastava" <pranjas@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Pranay Kr. Srivastava" <pranjas@gmail.com>
Subject: [PATCH 0/1]ext4: Fix for WARN_ON_ONCE when marking buffer dirty
Date: Thu, 30 Jun 2016 14:12:29 +0300	[thread overview]
Message-ID: <1467285150-15977-1-git-send-email-pranjas@gmail.com> (raw)


1) Fix WARN_ON_ONCE when marking buffer dirty
   it's possible that a writeback for the super block
   buffer head is triggered after setting the buffer
   uptodate on a buffer write_io_error.

   If however there's an error while writing the buffer
   head then the buffer is cleared from being uptodate.

   If the buffer uptodate is not set while calling
   mark_buffer_dirty, it throws a WARN_ON_ONCE.
   This patch fixes it by locking the buffer while marking
   the buffer uptodate and then marking it dirty while holding
   the buffer head lock.


Pranay Kr. Srivastava (5):
   Fix WARN_ON_ONCE when marking buffer dirty

 fs/ext4/super.c     |  30 +++++-----
 1 files changed, 16 insertions(+), 14 deletions(-)

-- 
1.9.1

             reply	other threads:[~2016-06-30 11:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 11:12 Pranay Kr. Srivastava [this message]
2016-06-30 11:12 ` [PATCH 1/1]ext4: Fix WARN_ON_ONCE when marking buffer dirty Pranay Kr. Srivastava
2016-07-04  7:09   ` Pranay Srivastava
2016-07-04 14:29   ` Theodore Ts'o
2016-07-05  3:27     ` Pranay Srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467285150-15977-1-git-send-email-pranjas@gmail.com \
    --to=pranjas@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).