From: Eric Biggers <ebiggers@google.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, tytso@mit.edu,
jaegeuk@kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] fscrypto: make fname_encrypt() actually return length of ciphertext
Date: Wed, 14 Sep 2016 13:57:13 -0700 [thread overview]
Message-ID: <1473886634-24627-2-git-send-email-ebiggers@google.com> (raw)
In-Reply-To: <1473886634-24627-1-git-send-email-ebiggers@google.com>
This makes the return value match the comment. Previously it would
actually return 0 if encryption was successful. No callers currently
care, but this change should reduce the chance of future bugs.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/crypto/fname.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/crypto/fname.c b/fs/crypto/fname.c
index 3108806..7f3239c 100644
--- a/fs/crypto/fname.c
+++ b/fs/crypto/fname.c
@@ -103,12 +103,13 @@ static int fname_encrypt(struct inode *inode,
}
kfree(alloc_buf);
skcipher_request_free(req);
- if (res < 0)
+ if (res < 0) {
printk_ratelimited(KERN_ERR
"%s: Error (error code %d)\n", __func__, res);
next prev parent reply other threads:[~2016-09-14 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 20:57 [PATCH] fscrypto: remove unnecessary includes Eric Biggers
2016-09-14 20:57 ` Eric Biggers [this message]
2016-09-14 21:37 ` [PATCH] fscrypto: make fname_encrypt() actually return length of ciphertext Andreas Dilger
2016-09-14 21:57 ` Eric Biggers
2016-09-14 23:00 ` Eric Biggers
2016-09-14 20:57 ` [PATCH] fscrypto: rename completion callbacks to reflect usage Eric Biggers
2016-09-15 20:56 ` Theodore Ts'o
2016-09-15 20:48 ` fscrypto: remove unnecessary includes Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473886634-24627-2-git-send-email-ebiggers@google.com \
--to=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).