* [PATCH] ext4: get rid of ext4_sb_has_crypto()
@ 2016-11-22 0:22 Eric Biggers
2016-12-01 16:54 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2016-11-22 0:22 UTC (permalink / raw)
To: linux-ext4
Cc: Theodore Ts'o, Andreas Dilger, Jaegeuk Kim,
Richard Weinberger, Eric Biggers
ext4_sb_has_crypto() just called through to ext4_has_feature_encrypt(),
and all callers except one were already using the latter. So remove it
and switch its one caller to ext4_has_feature_encrypt().
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/ext4/ext4.h | 5 -----
fs/ext4/ioctl.c | 2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index a8a750f..cc83482 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2277,11 +2277,6 @@ extern unsigned ext4_free_clusters_after_init(struct super_block *sb,
struct ext4_group_desc *gdp);
ext4_fsblk_t ext4_inode_to_goal_block(struct inode *);
-static inline int ext4_sb_has_crypto(struct super_block *sb)
-{
- return ext4_has_feature_encrypt(sb);
-}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: get rid of ext4_sb_has_crypto()
2016-11-22 0:22 [PATCH] ext4: get rid of ext4_sb_has_crypto() Eric Biggers
@ 2016-12-01 16:54 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2016-12-01 16:54 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-ext4, Andreas Dilger, Jaegeuk Kim, Richard Weinberger
On Mon, Nov 21, 2016 at 04:22:12PM -0800, Eric Biggers wrote:
> ext4_sb_has_crypto() just called through to ext4_has_feature_encrypt(),
> and all callers except one were already using the latter. So remove it
> and switch its one caller to ext4_has_feature_encrypt().
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-01 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-22 0:22 [PATCH] ext4: get rid of ext4_sb_has_crypto() Eric Biggers
2016-12-01 16:54 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).