* [PATCH] ext4: fix spelling of "don't"
@ 2017-03-21 5:20 Benjamin Peterson
2017-03-25 19:55 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Peterson @ 2017-03-21 5:20 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4
Signed-off-by: Benjamin Peterson <bp@benjamin.pe>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 7385e6a..4247d8d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5400,7 +5400,7 @@ int ext4_getattr(const struct path *path, struct
kstat *stat,
* If there is inline data in the inode, the inode will normally
not
* have data blocks allocated (it may have an external xattr
block).
* Report at least one sector for such files, so tools like tar,
rsync,
- * others doen't incorrectly think the file is completely
sparse.
+ * others don't incorrectly think the file is completely sparse.
*/
if (unlikely(ext4_has_inline_data(inode)))
stat->blocks += (stat->size + 511) >> 9;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix spelling of "don't"
2017-03-21 5:20 [PATCH] ext4: fix spelling of "don't" Benjamin Peterson
@ 2017-03-25 19:55 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-03-25 19:55 UTC (permalink / raw)
To: Benjamin Peterson; +Cc: linux-ext4
On Mon, Mar 20, 2017 at 10:20:11PM -0700, Benjamin Peterson wrote:
> Signed-off-by: Benjamin Peterson <bp@benjamin.pe>
Hi Benjamin,
I generally don't take spelling fixes unless it's part of a
related code change. If you are a beginning kernel developer, most of
kernelnewbies tutorials advise beginners to send patches to the code
in the drivers/staging directory.
Also, please note that this patch arrived white-space damaged. I'm
guessing it's because you are using a web-based engine, and it
line-wraped the patch, thus damaging it:
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 7385e6a..4247d8d 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5400,7 +5400,7 @@ int ext4_getattr(const struct path *path, struct
> kstat *stat,
> * If there is inline data in the inode, the inode will normally
> not
^^^^ webmail damage
> * have data blocks allocated (it may have an external xattr
> block).
^^^^ webmail damage
> * Report at least one sector for such files, so tools like tar,
> rsync,
^^^^ webmail damage
> - * others doen't incorrectly think the file is completely
> sparse.
^^^^ webmail damage
> + * others don't incorrectly think the file is completely sparse.
> */
> if (unlikely(ext4_has_inline_data(inode)))
> stat->blocks += (stat->size + 511) >> 9;
Cheers,
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-25 19:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21 5:20 [PATCH] ext4: fix spelling of "don't" Benjamin Peterson
2017-03-25 19:55 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).