From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH v6 12/20] fs: add a new fstype flag to indicate how
 writeback errors are tracked
Date: Thu, 15 Jun 2017 11:03:24 -0400
Message-ID: <1497539004.4607.7.camel@redhat.com>
References: <20170612122316.13244-1-jlayton@redhat.com>
         <20170612122316.13244-15-jlayton@redhat.com>
         <20170612124513.GC18360@infradead.org> <1497349472.5762.1.camel@redhat.com>
         <20170614064731.GB3598@infradead.org> <1497461083.6752.7.camel@redhat.com>
         <20170615082221.GA22809@infradead.org> <1497523332.4556.1.camel@redhat.com>
         <20170615145724.GB14028@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>,
        tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com,
        ross.zwisler@linux.intel.com, corbet@lwn.net,
        Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
        David Sterba <dsterba@suse.com>,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-ext4-owner@vger.kernel.org>
Received: from mail-qt0-f177.google.com ([209.85.216.177]:36651 "EHLO
        mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753012AbdFOPD2 (ORCPT
        <rfc822;linux-ext4@vger.kernel.org>); Thu, 15 Jun 2017 11:03:28 -0400
Received: by mail-qt0-f177.google.com with SMTP id u19so23926044qta.3
        for <linux-ext4@vger.kernel.org>; Thu, 15 Jun 2017 08:03:28 -0700 (PDT)
In-Reply-To: <20170615145724.GB14028@infradead.org>
Sender: linux-ext4-owner@vger.kernel.org
List-ID: <linux-ext4.vger.kernel.org>

On Thu, 2017-06-15 at 07:57 -0700, Christoph Hellwig wrote:
> On Thu, Jun 15, 2017 at 06:42:12AM -0400, Jeff Layton wrote:
> > Correct.
> > 
> > But if there is a data writeback error, should we report an error on all
> > open fds at that time (like we will for fsync)?
> 
> We should in theory, but I don't see how to properly do it.  In addition
> sync_file_range just can't be used for data integrity to start with, so
> I don't think it's worth it.  At some point we should add a proper
> fsync_range syscall, though.

filemap_report_wb_err will always return 0 if the inode never has
mapping_set_error called on it. So, I think we should be able to do it
there once we get all of the fs' converted over. That'll have to happen
at the end of the series however.

-- 
Jeff Layton <jlayton@redhat.com>