Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes

Theodore Ts'o
2017-10-03T16:17:17Z

On Tue, Oct 03, 2017 at 12:31:45PM +0300, Nikolay Borisov wrote:
>
>
> On 3.10.2017 10:00, Zheng Lv wrote:
> >> No functional changes, just makes the code a bit more readable. Also fix 1
> >> trailing whitespace
> >
> > I don't think so.
> >
> > AFAIK, SZ_16 is just 16, not (16 * 1024). XXX * 1024 should be replaced with
> > SZ_XXXk rather than SZ_XXX.
>
> True, I meant kilobytes and not bytes, so my bad. THe patch is buggy
> will redo it and resend. Thanks for spotting it.

The symbolic constants don't also seem to add much in terms of
readability, at least to my view....

- Ted