Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes

Nikolay Borisov
2017-10-03T09:31:48Z

On 3.10.2017 10:00, Zheng Lv wrote:
>> No functional changes, just makes the code a bit more readable. Also fix 1
>> trailing whitespace
>
> I don't think so.
>
> AFAIK, SZ_16 is just 16, not (16 * 1024). XXX * 1024 should be replaced with
> SZ_XXXk rather than SZ_XXX.

True, I meant kilobytes and not bytes, so my bad. THe patch is buggy
will redo it and resend. Thanks for spotting it.

>
> Cheers
> Zheng Lv
>