From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valdis.Kletnieks@vt.edu Subject: mmotm 2009-07-16-14-32 - lockdep whinge in ext3/quota code Date: Wed, 22 Jul 2009 09:17:49 -0400 Message-ID: <15072.1248268669@turing-police.cc.vt.edu> References: <200907162134.n6GLY2kt019816@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1248268669_3794P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org To: Andrew Morton , Jan Kara , Stephen Tweedie , Andreas Dilger Return-path: Received: from turing-police.cc.vt.edu ([128.173.14.107]:50509 "EHLO turing-police.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbZGVNSZ (ORCPT ); Wed, 22 Jul 2009 09:18:25 -0400 In-Reply-To: Your message of "Thu, 16 Jul 2009 14:34:02 PDT." <200907162134.n6GLY2kt019816@imap1.linux-foundation.org> In-Reply-To: <200907162134.n6GLY2kt019816@imap1.linux-foundation.org> (Thu, 16 Jul 2009 14:34:02 PDT) Sender: linux-ext4-owner@vger.kernel.org List-ID: --==_Exmh_1248268669_3794P Content-Type: text/plain; charset=us-ascii Saw this while bisecting to find another issue. quilt top: memcg-add-comments-explaining-memory-barriers-checkpatch-fixes.patch Some checking doesn't look like any of the 58 patches after that are relevant (only the reiser4 patch references quotas, no grep hits for lockdep or ext3). About 30 seconds after boot: ======================================================= [ INFO: possible circular locking dependency detected ] 2.6.31-rc3 #2 ------------------------------------------------------- rm/1562 is trying to acquire lock: (&sb->s_type->i_mutex_key#11/4){+.+...}, at: [] ext3_quota_write+0xb5/0x274 but task is already holding lock: (&s->s_dquot.dqio_mutex){+.+...}, at: [] dquot_commit+0x26/0xee which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&s->s_dquot.dqio_mutex){+.+...}: [] __lock_acquire+0xa1b/0xb97 [] lock_acquire+0xec/0x110 [] __mutex_lock_common+0x5a/0x54e [] mutex_lock_nested+0x32/0x37 [] vfs_load_quota_inode+0x264/0x496 [] vfs_quota_on_path+0x4c/0x55 [] ext3_quota_on+0x14c/0x167 [] do_quotactl+0xf4/0x44c [] sys_quotactl+0x2ea/0x30e [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff -> #0 (&sb->s_type->i_mutex_key#11/4){+.+...}: [] __lock_acquire+0x8f8/0xb97 [] lock_acquire+0xec/0x110 [] __mutex_lock_common+0x5a/0x54e [] mutex_lock_nested+0x32/0x37 [] ext3_quota_write+0xb5/0x274 [] qtree_write_dquot+0xce/0x127 [] v2_write_dquot+0x27/0x29 [] dquot_commit+0x9d/0xee [] ext3_write_dquot+0x69/0x8a [] dqput+0x138/0x25c [] dquot_drop+0x6a/0x74 [] vfs_dq_drop+0x41/0x43 [] ext3_free_inode+0x96/0x28c [] ext3_delete_inode+0xbf/0xdd [] generic_delete_inode+0x135/0x1db [] generic_drop_inode+0x17/0x56 [] iput+0x7a/0x7f [] do_unlinkat+0x123/0x176 [] sys_unlinkat+0x24/0x26 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff other info that might help us debug this: 2 locks held by rm/1562: #0: (jbd_handle){+.+...}, at: [] journal_start+0x10a/0x137 #1: (&s->s_dquot.dqio_mutex){+.+...}, at: [] dquot_commit+0x26/0xee stack backtrace: Pid: 1562, comm: rm Not tainted 2.6.31-rc3 #2 Call Trace: [] print_circular_bug_tail+0x71/0x7c [] __lock_acquire+0x8f8/0xb97 [] ? ext3_quota_write+0xb5/0x274 [] lock_acquire+0xec/0x110 [] ? ext3_quota_write+0xb5/0x274 [] __mutex_lock_common+0x5a/0x54e [] ? ext3_quota_write+0xb5/0x274 [] ? check_irq_usage+0xad/0xbe [] ? ext3_quota_write+0xb5/0x274 [] ? __lock_acquire+0xaed/0xb97 [] mutex_lock_nested+0x32/0x37 [] ext3_quota_write+0xb5/0x274 [] qtree_write_dquot+0xce/0x127 [] ? get_parent_ip+0x11/0x42 [] v2_write_dquot+0x27/0x29 [] dquot_commit+0x9d/0xee [] ext3_write_dquot+0x69/0x8a [] dqput+0x138/0x25c [] dquot_drop+0x6a/0x74 [] vfs_dq_drop+0x41/0x43 [] ext3_free_inode+0x96/0x28c [] ? ext3_mark_inode_dirty+0x48/0x53 [] ext3_delete_inode+0xbf/0xdd [] ? ext3_delete_inode+0x0/0xdd [] generic_delete_inode+0x135/0x1db [] generic_drop_inode+0x17/0x56 [] iput+0x7a/0x7f [] do_unlinkat+0x123/0x176 [] ? audit_syscall_entry+0x170/0x19c [] sys_unlinkat+0x24/0x26 [] system_call_fastpath+0x16/0x1b --==_Exmh_1248268669_3794P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFKZxF9cC3lWbTT17ARAtBoAKCh8RjcD2vDpAz40mQMdwBQIoEtLACg9cKx YnQ/jrYuG2bLn/UiJdb09iY= =mloo -----END PGP SIGNATURE----- --==_Exmh_1248268669_3794P--