[PATCH 1/2] generic/458: document the fix commit

[PATCH 1/2] generic/458: document the fix commit

[Amir Goldstein]

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/generic/458 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/generic/458 b/tests/generic/458
index 7b408cb..730561f 100755
--- a/tests/generic/458
+++ b/tests/generic/458
@@ -4,6 +4,9 @@
 # Regression test for xfs leftover CoW extents after truncate
 # and umount
 #
+# Fixed by commit 3af423b03435 ("xfs: evict CoW fork extents when performing
+# finsert/fcollapse")
+#
 #-----------------------------------------------------------------------
 # Copyright (C) 2017 CTERA Networks. All Rights Reserved.
 # Author: Amir Goldstein <amir73il@gmail.com>
-- 
2.7.4

[PATCH 2/2] generic/456: document the fix commit

[Amir Goldstein]

Add a link to Ted's post with more details about the bug
and the fix.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

Eryu,

It may be better to include a digest of the refered post embedded
in the test. For now, I just added the link to mailing list archive.
Maybe Ted can add the digest later.

Thanks,
Amir.

 tests/generic/456 | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/generic/456 b/tests/generic/456
index 8debd3f..ed3cacc 100755
--- a/tests/generic/456
+++ b/tests/generic/456
@@ -4,6 +4,9 @@
 # This test is motivated by a bug found in ext4 during random crash
 # consistency tests.
 #
+# Fixed by commit 51e3ae81ec58 ("ext4: fix interaction between i_size,
+# fallocate, and delalloc after a crash")
+#
 #-----------------------------------------------------------------------
 # Copyright (C) 2017 CTERA Networks. All Rights Reserved.
 # Author: Amir Goldstein <amir73il@gmail.com>
@@ -58,6 +61,8 @@ _require_metadata_journaling $SCRATCH_DEV
 _init_flakey
 _mount_flakey
 
+# See this post for reverse engineering of this auto generated test:
+# https://marc.info/?l=linux-ext4&m=151137380830381&w=2
 fsxops=$tmp.fsxops
 cat <<EOF > $fsxops
 write 0x137dd 0xdc69 0x0
-- 
2.7.4

Re: [PATCH 1/2] generic/458: document the fix commit

[Darrick J. Wong]

On Thu, Nov 23, 2017 at 08:43:42AM +0200, Amir Goldstein wrote:
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  tests/generic/458 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/generic/458 b/tests/generic/458
> index 7b408cb..730561f 100755
> --- a/tests/generic/458
> +++ b/tests/generic/458
> @@ -4,6 +4,9 @@
>  # Regression test for xfs leftover CoW extents after truncate
>  # and umount
>  #
> +# Fixed by commit 3af423b03435 ("xfs: evict CoW fork extents when performing
> +# finsert/fcollapse")
> +#
>  #-----------------------------------------------------------------------
>  # Copyright (C) 2017 CTERA Networks. All Rights Reserved.
>  # Author: Amir Goldstein <amir73il@gmail.com>
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] generic/456: document the fix commit

[Theodore Ts'o]

On Thu, Nov 23, 2017 at 08:43:43AM +0200, Amir Goldstein wrote:
> Add a link to Ted's post with more details about the bug
> and the fix.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

I'm OK with this, so:

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

> It may be better to include a digest of the refered post embedded
> in the test. For now, I just added the link to mailing list archive.
> Maybe Ted can add the digest later.

Eryu can chime in if he links, but in general we haven't included long
discourses describing the bug in xfstests, so I don't think that's
really necessary.

					- Ted