* [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error
@ 2017-12-15 2:32 zhouzhouyi
2018-01-11 18:13 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: zhouzhouyi @ 2017-12-15 2:32 UTC (permalink / raw)
To: tytso, adilger.kernel, linux-ext4, linux-kernel; +Cc: Zhouyi Zhou
From: Zhouyi Zhou <zhouzhouyi@gmail.com>
In function __ext4_grp_locked_error, __save_error_info
is called to save error info in super block block, but does not sync
that information to disk to info the subsequence fsck after reboot.
This patch sync the error information to disk. After this patch,
I think there is no obvious EXT4 error handle branche which leads to
"Remounting filesystem read-only" will leave the disk partition miss
the subsequence fsck.
Compiled in x86_64 Linux
Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
---
fs/ext4/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 7c46693..7159438 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -742,6 +742,7 @@ __acquires(bitlock)
}
ext4_unlock_group(sb, grp);
+ ext4_commit_super(sb, 1);
ext4_handle_error(sb);
/*
* We only get here in the ERRORS_RO case; relocking the group
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error
2017-12-15 2:32 [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error zhouzhouyi
@ 2018-01-11 18:13 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2018-01-11 18:13 UTC (permalink / raw)
To: zhouzhouyi; +Cc: adilger.kernel, linux-ext4, linux-kernel
On Fri, Dec 15, 2017 at 02:32:16AM +0000, zhouzhouyi@gmail.com wrote:
> From: Zhouyi Zhou <zhouzhouyi@gmail.com>
>
> In function __ext4_grp_locked_error, __save_error_info
> is called to save error info in super block block, but does not sync
> that information to disk to info the subsequence fsck after reboot.
>
> This patch sync the error information to disk. After this patch,
> I think there is no obvious EXT4 error handle branche which leads to
> "Remounting filesystem read-only" will leave the disk partition miss
> the subsequence fsck.
>
> Compiled in x86_64 Linux
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-11 18:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 2:32 [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error zhouzhouyi
2018-01-11 18:13 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).