* [PATCH] ext2: Remove redundant check on s_inode_size
@ 2019-01-15 14:10 Liu Xiang
2019-01-22 10:38 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Liu Xiang @ 2019-01-15 14:10 UTC (permalink / raw)
To: linux-ext4; +Cc: jack, linux-kernel, liuxiang_1999, Liu Xiang
The case of (EXT2_INODE_SIZE(sb) == 0) is included in
(sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE).
So there is no need to check again.
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
fs/ext2/super.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 73b2d52..c71c2e3 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1024,8 +1024,6 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
sbi->s_frags_per_group = le32_to_cpu(es->s_frags_per_group);
sbi->s_inodes_per_group = le32_to_cpu(es->s_inodes_per_group);
- if (EXT2_INODE_SIZE(sb) == 0)
- goto cantfind_ext2;
sbi->s_inodes_per_block = sb->s_blocksize / EXT2_INODE_SIZE(sb);
if (sbi->s_inodes_per_block == 0 || sbi->s_inodes_per_group == 0)
goto cantfind_ext2;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext2: Remove redundant check on s_inode_size
2019-01-15 14:10 [PATCH] ext2: Remove redundant check on s_inode_size Liu Xiang
@ 2019-01-22 10:38 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-01-22 10:38 UTC (permalink / raw)
To: Liu Xiang; +Cc: linux-ext4, jack, linux-kernel, liuxiang_1999
On Tue 15-01-19 22:10:43, Liu Xiang wrote:
> The case of (EXT2_INODE_SIZE(sb) == 0) is included in
> (sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE).
> So there is no need to check again.
>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
Thanks for the cleanup. I have added it to my tree.
Honza
> ---
> fs/ext2/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 73b2d52..c71c2e3 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1024,8 +1024,6 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
> sbi->s_frags_per_group = le32_to_cpu(es->s_frags_per_group);
> sbi->s_inodes_per_group = le32_to_cpu(es->s_inodes_per_group);
>
> - if (EXT2_INODE_SIZE(sb) == 0)
> - goto cantfind_ext2;
> sbi->s_inodes_per_block = sb->s_blocksize / EXT2_INODE_SIZE(sb);
> if (sbi->s_inodes_per_block == 0 || sbi->s_inodes_per_group == 0)
> goto cantfind_ext2;
> --
> 1.9.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-22 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-15 14:10 [PATCH] ext2: Remove redundant check on s_inode_size Liu Xiang
2019-01-22 10:38 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).