linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "zhangyi (F)" <yi.zhang@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <jack@suse.cz>, <adilger.kernel@dilger.ca>,
	<yi.zhang@huawei.com>, <miaoxie@huawei.com>
Subject: [PATCH v3 0/4] ext4: fix a data corruption problem
Date: Fri, 25 Jan 2019 20:30:52 +0800	[thread overview]
Message-ID: <1548419456-4331-1-git-send-email-yi.zhang@huawei.com> (raw)

Hi:

This patch set is the third version which want to fix a data corruption,
have been testd by xfstests.

 - The first patch fix the data corruption problem we captured. The root
   case is that we forgot to clear dirty flag when revorking a buffer
   belongs to older transaction.
 - The second and third patches are cleanup patches which remove
   clean_bdev_aliases() related calls and move the logic to
   jbd2_journal_forget() when forgetting metadata (suggested by Jan Kara).
 - The last patch change the return value of ext4_ext_convert_to_initialized().

Please review.

Thanks,
Yi.

----------

Changes since v2:
 - Change the commit log and comments in the first patch.
 - Add the three cleanup patches to remove all clean_bdev_aliases() calls
   and change the return value of ext4_ext_convert_to_initialized().


zhangyi (F) (4):
  jbd2: make sure dirty flag is cleared while revorking a buffer which
    belongs to older transaction
  jbd2: discard dirty data when forgetting an un-journalled buffer
  ext4: cleanup clean_bdev_aliases() calls
  ext4: convert ext4_split_extent() to return requested length

 fs/ext4/extents.c     | 26 +++++++---------------
 fs/ext4/inode.c       |  7 ------
 fs/ext4/page-io.c     |  4 +---
 fs/jbd2/transaction.c | 60 +++++++++++++++++++++++++++++++++++++++++++--------
 4 files changed, 60 insertions(+), 37 deletions(-)

-- 
2.7.4


             reply	other threads:[~2019-01-25 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 12:30 zhangyi (F) [this message]
2019-01-25 12:30 ` [PATCH v3 1/4] jbd2: make sure dirty flag is cleared while revorking a buffer which belongs to older transaction zhangyi (F)
2019-01-28 15:24   ` Jan Kara
2019-01-25 12:30 ` [PATCH v3 2/4] jbd2: discard dirty data when forgetting an un-journalled buffer zhangyi (F)
2019-01-28 15:26   ` Jan Kara
2019-01-25 12:30 ` [PATCH v3 3/4] ext4: cleanup clean_bdev_aliases() calls zhangyi (F)
2019-01-28 15:26   ` Jan Kara
2019-01-25 12:30 ` [PATCH v3 4/4] ext4: convert ext4_split_extent() to return requested length zhangyi (F)
2019-01-28 15:39   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548419456-4331-1-git-send-email-yi.zhang@huawei.com \
    --to=yi.zhang@huawei.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).