From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B90B34028D9; Mon, 31 Aug 2026 12:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.118 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788179568; cv=none; b=q2lf44T8AucaQZ7S8AIvBUQlbN05h+JSxaZGtISl5zqB8QS/rX9RijJIMbSYkXgOIK2Q2q57iEnLuQ3w13lP0/elgENl53HZObVGqvdmoZ3BKbwLDylP2GFfSx0TFWFpJj/qvyjmEb16ZCXWbG0sXTHlvjjs0sHZWkMdFKWG3Ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788179568; c=relaxed/simple; bh=0iTP8H+ovE/Q0gNn8Cxe+FweOHnKpRIjv3V+bcPNU6U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KcpCJK/gbSeXb9Y7DKNlM97KZu8UUFISCpqnMZoR2nII7/+iOH0fyq/OLrLGKAn+OhZwGj+UEM/5rGj4jwwjV70IrZrbdedtBmSH2ErbYYQFiyfNor8I8e+mU+Vaej3SEK6+kJ8KORW9Muz75+aAR8Z2L4ZjjjvaMVCIAcmVmqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=WmpDWcMe; arc=none smtp.client-ip=115.124.30.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="WmpDWcMe" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1788179561; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=d7kMVnx2LblB7BHqjw+a56gGYnnF9uAQgrmNwvR5plE=; b=WmpDWcMeDT18m0AmkXO8QDGK2sYnHgGPTtyS4hLdv09g9gWiEasAJKsB37n5C2qEpBFWIg3Tth0dVWqvBrLIldYh9gdpN5lvpvRlGVY6SJCAOM9q1pBhFlrSZz3dZoBviUY/woq61fDp7/pxqLls+G0CBgfmgoU3cnvNCnCUPnA= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam011083073210;MF=libaokun@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0X9yvEG1_1788179558; Received: from 30.221.129.244(mailfrom:libaokun@linux.alibaba.com fp:SMTPD_---0X9yvEG1_1788179558 cluster:ay36) by smtp.aliyun-inc.com; Mon, 31 Aug 2026 20:32:39 +0800 Message-ID: <156326be-7d4a-4bdf-b0c0-030dc951af2e@linux.alibaba.com> Date: Mon, 31 Aug 2026 20:32:38 +0800 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] ext4: Remove uses of FGP_NOFS To: "Matthew Wilcox (Oracle)" Cc: Christian Brauner , Jan Kara , Gao Xiang , Chao Yu , Theodore Tso , Trond Myklebust , Anna Schumaker , Namjae Jeon , Hyunchul Lee , Phillip Lougher , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, ntfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20260830041901.2668-1-willy@infradead.org> <20260830041901.2668-3-willy@infradead.org> Content-Language: en-US From: Baokun Li In-Reply-To: <20260830041901.2668-3-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026/8/30 12:18, Matthew Wilcox (Oracle) wrote: > Both of these locations are called while a transaction is in progress. > Starting a transaction uses memalloc_nofs_save(), so we are already > prevented from recursing into the filesystem and using GFP_NOFS was > unnecessary. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good to me. Reviewed-by: Baokun Li > --- > fs/ext4/inline.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c > index ceee69a66482..1884abb09614 100644 > --- a/fs/ext4/inline.c > +++ b/fs/ext4/inline.c > @@ -601,9 +601,7 @@ static int ext4_convert_inline_data_to_extent(struct address_space *mapping, > goto out; > } > > - /* We cannot recurse into the filesystem as the transaction is already > - * started */ > - folio = __filemap_get_folio(mapping, 0, FGP_WRITEBEGIN | FGP_NOFS, > + folio = __filemap_get_folio(mapping, 0, FGP_WRITEBEGIN, > mapping_gfp_mask(mapping)); > if (IS_ERR(folio)) { > ret = PTR_ERR(folio); > @@ -734,7 +732,7 @@ int ext4_generic_write_inline_data(struct address_space *mapping, > goto out_release_bh; > } > > - folio = __filemap_get_folio(mapping, 0, FGP_WRITEBEGIN | FGP_NOFS, > + folio = __filemap_get_folio(mapping, 0, FGP_WRITEBEGIN, > mapping_gfp_mask(mapping)); > if (IS_ERR(folio)) { > ret = PTR_ERR(folio);