From: qiwuchen55@gmail.com
To: tytso@mit.edu, adilger.kernel@dilger.ca, trivial@kernel.org
Cc: linux-ext4@vger.kernel.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: [PATCH] ext4: remove trivial nowait check for buffered write
Date: Sat, 1 Feb 2020 12:00:39 +0800 [thread overview]
Message-ID: <1580529639-26328-1-git-send-email-qiwuchen55@gmail.com> (raw)
From: chenqiwu <chenqiwu@xiaomi.com>
Remove trivial nowait check for ext4_buffered_write_iter(),
since buffered writes will return -EINVAL if IOCB_NOWAIT
passed in the follow-up function ext4_write_checks()->
ext4_generic_write_checks()->generic_write_checks().
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
fs/ext4/file.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 5f22588..18ae435 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -258,9 +258,6 @@ static ssize_t ext4_buffered_write_iter(struct kiocb *iocb,
ssize_t ret;
struct inode *inode = file_inode(iocb->ki_filp);
- if (iocb->ki_flags & IOCB_NOWAIT)
- return -EOPNOTSUPP;
-
inode_lock(inode);
ret = ext4_write_checks(iocb, from);
if (ret <= 0)
--
1.9.1
next reply other threads:[~2020-02-01 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 4:00 qiwuchen55 [this message]
2020-02-01 22:49 ` [PATCH] ext4: remove trivial nowait check for buffered write Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1580529639-26328-1-git-send-email-qiwuchen55@gmail.com \
--to=qiwuchen55@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=chenqiwu@xiaomi.com \
--cc=linux-ext4@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).