From: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, Max Kellermann <max.kellermann@ionos.com>,
Jan Kara <jack@suse.com>, Miklos Szeredi <miklos@szeredi.hu>,
Christian Brauner <brauner@kernel.org>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ext4: Don't reduce symlink i_mode by umask if no ACL support
Date: Fri, 10 May 2024 12:46:12 +0100 [thread overview]
Message-ID: <1586841.1715341572@warthog.procyon.org.uk> (raw)
In-Reply-To: <1586576.1715341405@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> - inode->i_mode &= ~current_umask();
> + if (!S_ISLNK(inode->i_mode))
> + inode->i_mode &= ~current_umask();
Meh. I forgot to commit the change. Will resend.
David
prev parent reply other threads:[~2024-05-10 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:43 [PATCH v2] ext4: Don't reduce symlink i_mode by umask if no ACL support David Howells
2024-05-10 11:46 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586841.1715341572@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=brauner@kernel.org \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox