From: Chunguang Xu <brookxu.cn@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 4/8] ext4: add the gdt block of meta_bg to system_zone
Date: Wed, 21 Oct 2020 17:15:24 +0800 [thread overview]
Message-ID: <1603271728-7198-4-git-send-email-brookxu@tencent.com> (raw)
In-Reply-To: <1603271728-7198-1-git-send-email-brookxu@tencent.com>
From: Chunguang Xu <brookxu@tencent.com>
In order to avoid poor search efficiency of system_zone, the
system only adds metadata of some sparse group to system_zone.
In the meta_bg scenario, the non-sparse group may contain gdt
blocks. Perhaps we should add these blocks to system_zone to
improve fault tolerance without significantly reducing system
performance.
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
fs/ext4/block_validity.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
index 8e6ca23..37025e3 100644
--- a/fs/ext4/block_validity.c
+++ b/fs/ext4/block_validity.c
@@ -218,6 +218,7 @@ int ext4_setup_system_zone(struct super_block *sb)
struct ext4_group_desc *gdp;
ext4_group_t i;
int flex_size = ext4_flex_bg_size(sbi);
+ int gd_blks;
int ret;
system_blks = kzalloc(sizeof(*system_blks), GFP_KERNEL);
@@ -226,13 +227,16 @@ int ext4_setup_system_zone(struct super_block *sb)
for (i=0; i < ngroups; i++) {
cond_resched();
- if (ext4_bg_has_super(sb, i) &&
- ((i < 5) || ((i % flex_size) == 0))) {
- ret = add_system_zone(system_blks,
- ext4_group_first_block_no(sb, i),
- ext4_bg_num_gdb(sb, i) + 1, 0);
- if (ret)
- goto err;
+ if ((i < 5) || ((i % flex_size) == 0)) {
+ gd_blks = ext4_bg_has_super(sb, i) +
+ ext4_bg_num_gdb(sb, i);
+ if (gd_blks) {
+ ret = add_system_zone(system_blks,
+ ext4_group_first_block_no(sb, i),
+ gd_blks, 0);
+ if (ret)
+ goto err;
+ }
}
gdp = ext4_get_group_desc(sb, i, NULL);
ret = add_system_zone(system_blks,
--
1.8.3.1
next prev parent reply other threads:[~2020-10-21 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 9:15 [PATCH 1/8] ext4: use ext4_assert() to replace J_ASSERT() Chunguang Xu
2020-10-21 9:15 ` [PATCH 2/8] ext4: remove redundant mb_regenerate_buddy() Chunguang Xu
2020-10-23 22:58 ` Andreas Dilger
2020-10-21 9:15 ` [PATCH 3/8] ext4: simplify the code of mb_find_order_for_block Chunguang Xu
2020-10-23 23:07 ` Andreas Dilger
2020-10-21 9:15 ` Chunguang Xu [this message]
2020-10-21 9:15 ` [PATCH 5/8] ext4: update ext4_data_block_valid related comments Chunguang Xu
2020-10-23 23:09 ` Andreas Dilger
2020-10-21 9:15 ` [PATCH 6/8] ext4: add a helper function to validate metadata block Chunguang Xu
2020-10-21 9:15 ` [PATCH 7/8] ext4: delete invalid code inside ext4_xattr_block_set() Chunguang Xu
2020-10-23 23:10 ` Andreas Dilger
2020-10-21 9:15 ` [PATCH 8/8] ext4: fix a memory leak of ext4_free_data Chunguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603271728-7198-4-git-send-email-brookxu@tencent.com \
--to=brookxu.cn@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).