* [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro
@ 2020-11-12 6:56 xiakaixu1987
2020-12-10 16:18 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: xiakaixu1987 @ 2020-11-12 6:56 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, adilger.kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
There are no callers of the EXT4_CURRENT_REV macro, so remove it.
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
fs/ext4/ext4.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index bf9429484462..cf1c01139f26 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1858,7 +1858,6 @@ static inline bool ext4_verity_in_progress(struct inode *inode)
#define EXT4_GOOD_OLD_REV 0 /* The good old (original) format */
#define EXT4_DYNAMIC_REV 1 /* V2 format w/ dynamic inode sizes */
-#define EXT4_CURRENT_REV EXT4_GOOD_OLD_REV
#define EXT4_MAX_SUPP_REV EXT4_DYNAMIC_REV
#define EXT4_GOOD_OLD_INODE_SIZE 128
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro
2020-11-12 6:56 [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro xiakaixu1987
@ 2020-12-10 16:18 ` Jan Kara
2020-12-16 4:12 ` Theodore Y. Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2020-12-10 16:18 UTC (permalink / raw)
To: xiakaixu1987; +Cc: linux-ext4, tytso, adilger.kernel, Kaixu Xia
On Thu 12-11-20 14:56:42, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> There are no callers of the EXT4_CURRENT_REV macro, so remove it.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
I guess this has fallen through the cracks? The cleanup looks good to me.
You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/ext4.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index bf9429484462..cf1c01139f26 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1858,7 +1858,6 @@ static inline bool ext4_verity_in_progress(struct inode *inode)
> #define EXT4_GOOD_OLD_REV 0 /* The good old (original) format */
> #define EXT4_DYNAMIC_REV 1 /* V2 format w/ dynamic inode sizes */
>
> -#define EXT4_CURRENT_REV EXT4_GOOD_OLD_REV
> #define EXT4_MAX_SUPP_REV EXT4_DYNAMIC_REV
>
> #define EXT4_GOOD_OLD_INODE_SIZE 128
> --
> 2.20.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro
2020-12-10 16:18 ` Jan Kara
@ 2020-12-16 4:12 ` Theodore Y. Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-12-16 4:12 UTC (permalink / raw)
To: Jan Kara; +Cc: xiakaixu1987, linux-ext4, adilger.kernel, Kaixu Xia
On Thu, Dec 10, 2020 at 05:18:06PM +0100, Jan Kara wrote:
> On Thu 12-11-20 14:56:42, xiakaixu1987@gmail.com wrote:
> > From: Kaixu Xia <kaixuxia@tencent.com>
> >
> > There are no callers of the EXT4_CURRENT_REV macro, so remove it.
> >
> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
>
> I guess this has fallen through the cracks? The cleanup looks good to me.
> You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-16 4:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 6:56 [PATCH] ext4: remove the unused EXT4_CURRENT_REV macro xiakaixu1987
2020-12-10 16:18 ` Jan Kara
2020-12-16 4:12 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).