From: Chengguang Xu <cgxu519@mykernel.net>
To: "Jan Kara" <jack@suse.cz>
Cc: "jack" <jack@suse.com>, "linux-ext4" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 4/5] ext2: code cleanup for ext2_try_to_allocate()
Date: Thu, 07 Nov 2019 10:58:03 +0800 [thread overview]
Message-ID: <16e43cc2728.de6ac2bc928.3996069392231034746@mykernel.net> (raw)
In-Reply-To: <20191106155900.GC12685@quack2.suse.cz>
---- 在 星期三, 2019-11-06 23:59:00 Jan Kara <jack@suse.cz> 撰写 ----
> On Mon 04-11-19 19:40:35, Chengguang Xu wrote:
> > Code cleanup by removing duplicated code.
> >
> > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
>
> Thanks for the patch! I've merged it with a small update to switch the
> while() loop into a for() loop which is somewhat more natural in that
> situation. Resulting patch attached.
>
Looks fine to me.
Thanks,
Chengguang
next prev parent reply other threads:[~2019-11-07 2:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 11:40 [PATCH 1/5] ext2: introduce new helper ext2_group_last_block_no() Chengguang Xu
2019-11-04 11:40 ` [PATCH 2/5] ext2: code cleanup by calling ext2_group_last_block_no() Chengguang Xu
2019-11-06 15:42 ` Jan Kara
2019-11-07 2:54 ` Chengguang Xu
2019-11-07 9:21 ` Jan Kara
2019-11-07 9:44 ` Chengguang Xu
2019-11-07 11:36 ` Jan Kara
2019-11-04 11:40 ` [PATCH 3/5] ext2: skip unnecessary operations in ext2_try_to_allocate() Chengguang Xu
2019-11-04 11:40 ` [PATCH 4/5] ext2: code cleanup for ext2_try_to_allocate() Chengguang Xu
2019-11-06 15:59 ` Jan Kara
2019-11-07 2:58 ` Chengguang Xu [this message]
2019-11-04 11:40 ` [PATCH 5/5] ext2: fix improper function comment Chengguang Xu
2019-11-06 16:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e43cc2728.de6ac2bc928.3996069392231034746@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).