Re: why unlikely(rsv) in ext3_clear_inode()?

Steven Rostedt
2008-10-28T00:22:48Z

On Mon, 27 Oct 2008, Theodore Tso wrote:

> On Mon, Oct 27, 2008 at 07:32:11PM -0400, Steven Rostedt wrote:
> > Attached is a patch that I used for counting.
> >
> > Here's my results:
> > # cat /debug/tracing/ftrace_null
> > 45
> > # cat /debug/tracing/ftrace_nonnull
> > 7
> >
> > Ah, seems that there is cases where it is nonnull more often. Anyway, it
> > obviously is not a fast path (total of 52). Even if it was all null, it is
> > not big enough to call for the confusion.
>
> Silly question --- what was your test workload?

Hehe, I just booted the box. The counting started right away, so I just
looked at the work load.

Anyway, I'm writing a generic "unlikely" profiler that should make Andrew
happy. And this will also catch this case as well.

-- Steve