From: "Darrick J. Wong" <djwong@kernel.org>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 4/5] fuse2fs: make other logging consistent
Date: Thu, 24 Apr 2025 14:39:44 -0700 [thread overview]
Message-ID: <174553064527.1160047.12420605972373641844.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <174553064436.1160047.577374015997116030.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
Make all the other advisory messages have a consistent format.
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
misc/fuse2fs.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c
index e3e747dec33fd9..9fd35d14e10556 100644
--- a/misc/fuse2fs.c
+++ b/misc/fuse2fs.c
@@ -89,6 +89,12 @@ static ext2_filsys global_fs; /* Try not to use this directly */
break; \
}
+#define log_printf(fuse2fs, format, ...) \
+ do { \
+ printf("FUSE2FS (%s): " format, (fuse2fs)->shortdev, ##__VA_ARGS__); \
+ fflush(stdout); \
+ } while (0)
+
#define err_printf(fuse2fs, format, ...) \
do { \
fprintf(stderr, "FUSE2FS (%s): " format, (fuse2fs)->shortdev, ##__VA_ARGS__); \
@@ -3830,7 +3836,7 @@ int main(int argc, char *argv[])
if (fctx.norecovery)
fctx.ro = 1;
if (fctx.ro)
- printf("%s", _("Mounting read-only.\n"));
+ log_printf(&fctx, "%s\n", _("Mounting read-only."));
#ifdef ENABLE_NLS
setlocale(LC_MESSAGES, "");
@@ -3854,8 +3860,8 @@ int main(int argc, char *argv[])
/* Will we allow users to allocate every last block? */
if (getenv("FUSE2FS_ALLOC_ALL_BLOCKS")) {
- printf(_("%s: Allowing users to allocate all blocks. "
- "This is dangerous!\n"), fctx.device);
+ log_printf(&fctx, "%s\n",
+ _("Allowing users to allocate all blocks. This is dangerous!"));
fctx.alloc_all_blocks = 1;
}
@@ -3879,11 +3885,10 @@ int main(int argc, char *argv[])
if (ext2fs_has_feature_journal_needs_recovery(global_fs->super)) {
if (fctx.norecovery) {
- printf(_("%s: mounting read-only without "
- "recovering journal\n"),
- fctx.device);
+ log_printf(&fctx, "%s\n",
+ _("Mounting read-only without recovering journal."));
} else if (!fctx.ro) {
- printf(_("%s: recovering journal\n"), fctx.device);
+ log_printf(&fctx, "%s\n", _("Recovering journal."));
err = ext2fs_run_ext3_journal(&global_fs);
if (err) {
err_printf(&fctx, "%s.\n", error_message(err));
@@ -3902,8 +3907,8 @@ int main(int argc, char *argv[])
if (!fctx.ro) {
if (ext2fs_has_feature_journal(global_fs->super))
- printf(_("%s: Writing to the journal is not supported.\n"),
- fctx.device);
+ log_printf(&fctx, "%s\n",
+ _("Writing to the journal is not supported."));
err = ext2fs_read_inode_bitmap(global_fs);
if (err) {
translate_error(global_fs, 0, err);
next prev parent reply other threads:[~2025-04-24 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 21:38 [PATCHSET 1/5] fuse2fs: better logging Darrick J. Wong
2025-04-24 21:38 ` [PATCH 1/5] fuse2fs: enable runtime debugging Darrick J. Wong
2025-04-24 21:39 ` [PATCH 2/5] fuse2fs: stop aliasing stderr with ff->err_fp Darrick J. Wong
2025-07-20 8:27 ` Sam James
2025-07-20 18:51 ` Darrick J. Wong
2025-07-21 5:42 ` Darrick J. Wong
2025-07-21 11:41 ` Theodore Ts'o
2025-07-21 17:01 ` Darrick J. Wong
2025-04-24 21:39 ` [PATCH 3/5] fuse2fs: use error logging macro for mount errors Darrick J. Wong
2025-04-24 21:39 ` Darrick J. Wong [this message]
2025-04-24 21:40 ` [PATCH 5/5] fuse2fs: redirect all messages when FUSE2FS_LOGFILE is set Darrick J. Wong
2025-05-21 14:51 ` [PATCHSET 1/5] fuse2fs: better logging Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174553064527.1160047.12420605972373641844.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox