From: "Darrick J. Wong" <djwong@kernel.org>
To: tytso@mit.edu
Cc: John@groves.net, linux-ext4@vger.kernel.org, miklos@szeredi.hu,
joannelkoong@gmail.com, bernd@bsbernd.com,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 13/16] fuse2fs: don't do file data block IO when iomap is enabled
Date: Wed, 21 May 2025 17:14:14 -0700 [thread overview]
Message-ID: <174787198668.1484996.15426837869307835566.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <174787198370.1484996.3340565971108603226.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
When iomap is in use for the page cache, the kernel will take care of
all the file data block IO for us, including zeroing of punched ranges
and post-EOF bytes. fuse2fs only needs to do IO for inline data.
Therefore, set the NOBLOCKIO ext2_file flag so that libext2fs will not
do any regular file IO to or from disk blocks at all.
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
misc/fuse2fs.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c
index aeb2b6fbc28401..842ea3a191fa44 100644
--- a/misc/fuse2fs.c
+++ b/misc/fuse2fs.c
@@ -2863,9 +2863,14 @@ static int truncate_helper(struct fuse2fs *ff, ext2_ino_t ino, off_t new_size)
ext2_file_t file;
__u64 old_isize;
errcode_t err;
+ int flags = EXT2_FILE_WRITE;
int ret = 0;
- err = ext2fs_file_open(fs, ino, EXT2_FILE_WRITE, &file);
+ /* the kernel handles all eof zeroing for us in iomap mode */
+ if (iomap_does_fileio(ff))
+ flags |= EXT2_FILE_NOBLOCKIO;
+
+ err = ext2fs_file_open(fs, ino, flags, &file);
if (err)
return translate_error(fs, ino, err);
@@ -2987,6 +2992,9 @@ static int __op_open(struct fuse2fs *ff, const char *path,
file->open_flags |= EXT2_FILE_WRITE;
break;
}
+ /* the kernel handles all block IO for us in iomap mode */
+ if (iomap_does_fileio(ff))
+ file->open_flags |= EXT2_FILE_NOBLOCKIO;
if (fp->flags & O_APPEND) {
/* the kernel doesn't allow truncation of an append-only file */
if (fp->flags & O_TRUNC) {
next prev parent reply other threads:[~2025-05-22 0:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 23:58 [RFC[RAP]] fuse: use fs-iomap for better performance so we can containerize ext4 Darrick J. Wong
2025-05-22 0:01 ` [PATCHSET 1/3] fuse2fs: upgrade to libfuse 3.17 Darrick J. Wong
2025-05-22 0:07 ` [PATCH 1/3] fuse2fs: bump library version Darrick J. Wong
2025-05-22 0:07 ` [PATCH 2/3] fuse2fs: wrap the fuse_set_feature_flag helper for older libfuse Darrick J. Wong
2025-05-22 0:08 ` [PATCH 3/3] fuse2fs: disable nfs exports Darrick J. Wong
2025-05-22 0:02 ` [PATCHSET RFC[RAP] 2/3] libext2fs: refactoring for fuse2fs iomap support Darrick J. Wong
2025-05-22 0:08 ` [PATCH 01/10] libext2fs: always fsync the device when flushing the cache Darrick J. Wong
2025-05-22 0:08 ` [PATCH 02/10] libext2fs: always fsync the device when closing the unix IO manager Darrick J. Wong
2025-05-22 0:09 ` [PATCH 03/10] libext2fs: only fsync the unix fd if we wrote to the device Darrick J. Wong
2025-05-22 0:09 ` [PATCH 04/10] libext2fs: invalidate cached blocks when freeing them Darrick J. Wong
2025-05-22 0:09 ` [PATCH 05/10] libext2fs: add tagged block IO for better caching Darrick J. Wong
2025-05-22 0:09 ` [PATCH 06/10] libext2fs: add tagged block IO caching to the unix IO manager Darrick J. Wong
2025-05-22 0:10 ` [PATCH 07/10] libext2fs: only flush affected blocks in unix_write_byte Darrick J. Wong
2025-05-22 0:10 ` [PATCH 08/10] libext2fs: allow unix_write_byte when the write would be aligned Darrick J. Wong
2025-05-22 0:10 ` [PATCH 09/10] libext2fs: allow clients to ask to write full superblocks Darrick J. Wong
2025-05-22 0:10 ` [PATCH 10/10] libext2fs: allow callers to disallow I/O to file data blocks Darrick J. Wong
2025-05-22 0:02 ` [PATCHSET RFC[RAP] 3/3] fuse2fs: use fuse iomap data paths for better file I/O performance Darrick J. Wong
2025-05-22 0:11 ` [PATCH 01/16] fuse2fs: implement bare minimum iomap for file mapping reporting Darrick J. Wong
2025-05-22 0:11 ` [PATCH 02/16] fuse2fs: register block devices for use with iomap Darrick J. Wong
2025-05-22 0:11 ` [PATCH 03/16] fuse2fs: always use directio disk reads with fuse2fs Darrick J. Wong
2025-05-22 0:11 ` [PATCH 04/16] fuse2fs: implement directio file reads Darrick J. Wong
2025-05-22 0:12 ` [PATCH 05/16] fuse2fs: use tagged block IO for zeroing sub-block regions Darrick J. Wong
2025-05-22 0:12 ` [PATCH 06/16] fuse2fs: only flush the cache for the file under directio read Darrick J. Wong
2025-05-22 0:12 ` [PATCH 07/16] fuse2fs: add extent dump function for debugging Darrick J. Wong
2025-05-22 0:12 ` [PATCH 08/16] fuse2fs: implement direct write support Darrick J. Wong
2025-05-22 0:13 ` [PATCH 09/16] fuse2fs: turn on iomap for pagecache IO Darrick J. Wong
2025-05-22 0:13 ` [PATCH 10/16] fuse2fs: flush and invalidate the buffer cache on trim Darrick J. Wong
2025-05-22 0:13 ` [PATCH 11/16] fuse2fs: improve tracing for fallocate Darrick J. Wong
2025-05-22 0:13 ` [PATCH 12/16] fuse2fs: don't zero bytes in punch hole Darrick J. Wong
2025-05-22 0:14 ` Darrick J. Wong [this message]
2025-05-22 0:14 ` [PATCH 14/16] fuse2fs: disable most io channel flush/invalidate in iomap pagecache mode Darrick J. Wong
2025-05-22 0:14 ` [PATCH 15/16] fuse2fs: re-enable the block device pagecache for metadata IO Darrick J. Wong
2025-05-22 0:15 ` [PATCH 16/16] fuse2fs: avoid fuseblk mode if fuse-iomap support is likely Darrick J. Wong
2025-05-22 16:24 ` [RFC[RAP]] fuse: use fs-iomap for better performance so we can containerize ext4 Amir Goldstein
2025-05-29 16:45 ` Darrick J. Wong
2025-05-29 19:41 ` Amir Goldstein
2025-06-09 22:31 ` Darrick J. Wong
2025-06-10 10:59 ` Amir Goldstein
2025-06-10 19:00 ` Darrick J. Wong
2025-06-10 19:51 ` Amir Goldstein
2025-06-11 6:00 ` Darrick J. Wong
2025-06-11 8:54 ` Amir Goldstein
2025-06-12 5:54 ` Miklos Szeredi
2025-06-13 17:44 ` Darrick J. Wong
2025-06-11 11:56 ` Theodore Ts'o
2025-06-12 3:20 ` Darrick J. Wong
2025-06-12 6:10 ` Amir Goldstein
2025-06-20 8:58 ` Allison Karlitskaya
2025-06-20 11:50 ` Bernd Schubert
2025-07-01 6:02 ` Darrick J. Wong
2025-07-01 5:58 ` Darrick J. Wong
2025-07-12 10:57 ` Amir Goldstein
2025-06-13 17:37 ` [RFC[RAP] V2] " Darrick J. Wong
2025-06-23 13:16 ` Miklos Szeredi
2025-07-01 6:05 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174787198668.1484996.15426837869307835566.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=John@groves.net \
--cc=bernd@bsbernd.com \
--cc=joannelkoong@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox