From: "Darrick J. Wong" <djwong@kernel.org>
To: tytso@mit.edu
Cc: John@groves.net, bernd@bsbernd.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
miklos@szeredi.hu, amir73il@gmail.com, joannelkoong@gmail.com,
neal@gompa.dev
Subject: [PATCH 03/20] fuse4fs: namespace some helpers
Date: Wed, 20 Aug 2025 18:08:39 -0700 [thread overview]
Message-ID: <175573712861.20753.12678836494772235653.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <175573712721.20753.5223489399594191991.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
Prepend "fuse4fs_" to all helper functions that take a struct fuse4fs
object pointer.
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
misc/fuse4fs.c | 177 ++++++++++++++++++++++++++++----------------------------
1 file changed, 90 insertions(+), 87 deletions(-)
diff --git a/misc/fuse4fs.c b/misc/fuse4fs.c
index e6e5729936f6a1..124a16eb0614a8 100644
--- a/misc/fuse4fs.c
+++ b/misc/fuse4fs.c
@@ -2,6 +2,7 @@
* fuse4fs.c - FUSE low-level server for e2fsprogs.
*
* Copyright (C) 2014-2025 Oracle.
+ * Copyright (C) 2025 CTERA Networks.
*
* %Begin-Header%
* This file may be redistributed under the terms of the GNU Public
@@ -691,7 +692,7 @@ static int ext2_file_type(unsigned int mode)
return 0;
}
-static int fs_can_allocate(struct fuse4fs *ff, blk64_t num)
+static int fuse4fs_can_allocate(struct fuse4fs *ff, blk64_t num)
{
ext2_filsys fs = ff->fs;
blk64_t reserved;
@@ -718,21 +719,22 @@ static int fs_can_allocate(struct fuse4fs *ff, blk64_t num)
return ext2fs_free_blocks_count(fs->super) > reserved + num;
}
-static int fuse4fs_is_writeable(struct fuse4fs *ff)
+static int fuse4fs_is_writeable(const struct fuse4fs *ff)
{
return ff->opstate == F4OP_WRITABLE &&
(ff->fs->super->s_error_count == 0);
}
-static inline int is_superuser(struct fuse4fs *ff, struct fuse_context *ctxt)
+static inline int fuse4fs_is_superuser(struct fuse4fs *ff,
+ const struct fuse_context *ctxt)
{
if (ff->fakeroot)
return 1;
return ctxt->uid == 0;
}
-static inline int want_check_owner(struct fuse4fs *ff,
- struct fuse_context *ctxt)
+static inline int fuse4fs_want_check_owner(struct fuse4fs *ff,
+ const struct fuse_context *ctxt)
{
/*
* The kernel is responsible for access control, so we allow anything
@@ -740,14 +742,14 @@ static inline int want_check_owner(struct fuse4fs *ff,
*/
if (ff->kernel)
return 0;
- return !is_superuser(ff, ctxt);
+ return !fuse4fs_is_superuser(ff, ctxt);
}
/* Test for append permission */
#define A_OK 16
-static int check_iflags_access(struct fuse4fs *ff, ext2_ino_t ino,
- const struct ext2_inode *inode, int mask)
+static int fuse4fs_iflags_access(struct fuse4fs *ff, ext2_ino_t ino,
+ const struct ext2_inode *inode, int mask)
{
EXT2FS_BUILD_BUG_ON((A_OK & (R_OK | W_OK | X_OK | F_OK)) != 0);
@@ -775,7 +777,7 @@ static int check_iflags_access(struct fuse4fs *ff, ext2_ino_t ino,
return 0;
}
-static int check_inum_access(struct fuse4fs *ff, ext2_ino_t ino, int mask)
+static int fuse4fs_inum_access(struct fuse4fs *ff, ext2_ino_t ino, int mask)
{
struct fuse_context *ctxt = fuse_get_context();
ext2_filsys fs = ff->fs;
@@ -807,7 +809,7 @@ static int check_inum_access(struct fuse4fs *ff, ext2_ino_t ino, int mask)
if (mask == 0)
return 0;
- ret = check_iflags_access(ff, ino, &inode, mask);
+ ret = fuse4fs_iflags_access(ff, ino, &inode, mask);
if (ret)
return ret;
@@ -816,7 +818,7 @@ static int check_inum_access(struct fuse4fs *ff, ext2_ino_t ino, int mask)
return 0;
/* Figure out what root's allowed to do */
- if (is_superuser(ff, ctxt)) {
+ if (fuse4fs_is_superuser(ff, ctxt)) {
/* Non-file access always ok */
if (!LINUX_S_ISREG(inode.i_mode))
return 0;
@@ -1517,8 +1519,8 @@ static int op_readlink(const char *path, char *buf, size_t len)
return ret;
}
-static int __getxattr(struct fuse4fs *ff, ext2_ino_t ino, const char *name,
- void **value, size_t *value_len)
+static int fuse4fs_getxattr(struct fuse4fs *ff, ext2_ino_t ino,
+ const char *name, void **value, size_t *value_len)
{
ext2_filsys fs = ff->fs;
struct ext2_xattr_handle *h;
@@ -1548,8 +1550,8 @@ static int __getxattr(struct fuse4fs *ff, ext2_ino_t ino, const char *name,
return ret;
}
-static int __setxattr(struct fuse4fs *ff, ext2_ino_t ino, const char *name,
- void *value, size_t valuelen)
+static int fuse4fs_setxattr(struct fuse4fs *ff, ext2_ino_t ino,
+ const char *name, void *value, size_t valuelen)
{
ext2_filsys fs = ff->fs;
struct ext2_xattr_handle *h;
@@ -1579,8 +1581,8 @@ static int __setxattr(struct fuse4fs *ff, ext2_ino_t ino, const char *name,
return ret;
}
-static int propagate_default_acls(struct fuse4fs *ff, ext2_ino_t parent,
- ext2_ino_t child)
+static int fuse4fs_propagate_default_acls(struct fuse4fs *ff, ext2_ino_t parent,
+ ext2_ino_t child)
{
void *def;
size_t deflen;
@@ -1589,8 +1591,8 @@ static int propagate_default_acls(struct fuse4fs *ff, ext2_ino_t parent,
if (!ff->acl)
return 0;
- ret = __getxattr(ff, parent, XATTR_NAME_POSIX_ACL_DEFAULT, &def,
- &deflen);
+ ret = fuse4fs_getxattr(ff, parent, XATTR_NAME_POSIX_ACL_DEFAULT, &def,
+ &deflen);
switch (ret) {
case -ENODATA:
case -ENOENT:
@@ -1602,7 +1604,8 @@ static int propagate_default_acls(struct fuse4fs *ff, ext2_ino_t parent,
return ret;
}
- ret = __setxattr(ff, child, XATTR_NAME_POSIX_ACL_DEFAULT, def, deflen);
+ ret = fuse4fs_setxattr(ff, child, XATTR_NAME_POSIX_ACL_DEFAULT, def,
+ deflen);
ext2fs_free_mem(&def);
return ret;
}
@@ -1731,7 +1734,7 @@ static int op_mknod(const char *path, mode_t mode, dev_t dev)
*node_name = 0;
fs = fuse4fs_start(ff);
- if (!fs_can_allocate(ff, 2)) {
+ if (!fuse4fs_can_allocate(ff, 2)) {
ret = -ENOSPC;
goto out2;
}
@@ -1743,7 +1746,7 @@ static int op_mknod(const char *path, mode_t mode, dev_t dev)
goto out2;
}
- ret = check_inum_access(ff, parent, A_OK | W_OK);
+ ret = fuse4fs_inum_access(ff, parent, A_OK | W_OK);
if (ret)
goto out2;
@@ -1813,7 +1816,7 @@ static int op_mknod(const char *path, mode_t mode, dev_t dev)
ext2fs_inode_alloc_stats2(fs, child, 1, 0);
- ret = propagate_default_acls(ff, parent, child);
+ ret = fuse4fs_propagate_default_acls(ff, parent, child);
if (ret)
goto out2;
@@ -1861,7 +1864,7 @@ static int op_mkdir(const char *path, mode_t mode)
*node_name = 0;
fs = fuse4fs_start(ff);
- if (!fs_can_allocate(ff, 1)) {
+ if (!fuse4fs_can_allocate(ff, 1)) {
ret = -ENOSPC;
goto out2;
}
@@ -1873,7 +1876,7 @@ static int op_mkdir(const char *path, mode_t mode)
goto out2;
}
- ret = check_inum_access(ff, parent, A_OK | W_OK);
+ ret = fuse4fs_inum_access(ff, parent, A_OK | W_OK);
if (ret)
goto out2;
@@ -1946,7 +1949,7 @@ static int op_mkdir(const char *path, mode_t mode)
goto out3;
}
- ret = propagate_default_acls(ff, parent, child);
+ ret = fuse4fs_propagate_default_acls(ff, parent, child);
if (ret)
goto out3;
@@ -1987,7 +1990,7 @@ static int fuse4fs_unlink(struct fuse4fs *ff, const char *path,
base_name = filename;
}
- ret = check_inum_access(ff, dir, W_OK);
+ ret = fuse4fs_inum_access(ff, dir, W_OK);
if (ret) {
free(filename);
return ret;
@@ -2009,8 +2012,8 @@ static int fuse4fs_unlink(struct fuse4fs *ff, const char *path,
return 0;
}
-static int remove_ea_inodes(struct fuse4fs *ff, ext2_ino_t ino,
- struct ext2_inode_large *inode)
+static int fuse4fs_remove_ea_inodes(struct fuse4fs *ff, ext2_ino_t ino,
+ struct ext2_inode_large *inode)
{
ext2_filsys fs = ff->fs;
struct ext2_xattr_handle *h;
@@ -2054,7 +2057,7 @@ static int remove_ea_inodes(struct fuse4fs *ff, ext2_ino_t ino,
return 0;
}
-static int remove_inode(struct fuse4fs *ff, ext2_ino_t ino)
+static int fuse4fs_remove_inode(struct fuse4fs *ff, ext2_ino_t ino)
{
ext2_filsys fs = ff->fs;
errcode_t err;
@@ -2087,7 +2090,7 @@ static int remove_inode(struct fuse4fs *ff, ext2_ino_t ino)
goto write_out;
if (ext2fs_has_feature_ea_inode(fs->super)) {
- ret = remove_ea_inodes(ff, ino, &inode);
+ ret = fuse4fs_remove_ea_inodes(ff, ino, &inode);
if (ret)
return ret;
}
@@ -2128,7 +2131,7 @@ static int __op_unlink(struct fuse4fs *ff, const char *path)
goto out;
}
- ret = check_inum_access(ff, ino, W_OK);
+ ret = fuse4fs_inum_access(ff, ino, W_OK);
if (ret)
goto out;
@@ -2136,7 +2139,7 @@ static int __op_unlink(struct fuse4fs *ff, const char *path)
if (ret)
goto out;
- ret = remove_inode(ff, ino);
+ ret = fuse4fs_remove_inode(ff, ino);
if (ret)
goto out;
@@ -2204,7 +2207,7 @@ static int __op_rmdir(struct fuse4fs *ff, const char *path)
}
dbg_printf(ff, "%s: rmdir path=%s ino=%d\n", __func__, path, child);
- ret = check_inum_access(ff, child, W_OK);
+ ret = fuse4fs_inum_access(ff, child, W_OK);
if (ret)
goto out;
@@ -2223,7 +2226,7 @@ static int __op_rmdir(struct fuse4fs *ff, const char *path)
goto out;
}
- ret = check_inum_access(ff, rds.parent, W_OK);
+ ret = fuse4fs_inum_access(ff, rds.parent, W_OK);
if (ret)
goto out;
@@ -2236,10 +2239,10 @@ static int __op_rmdir(struct fuse4fs *ff, const char *path)
if (ret)
goto out;
/* Directories have to be "removed" twice. */
- ret = remove_inode(ff, child);
+ ret = fuse4fs_remove_inode(ff, child);
if (ret)
goto out;
- ret = remove_inode(ff, child);
+ ret = fuse4fs_remove_inode(ff, child);
if (ret)
goto out;
@@ -2321,7 +2324,7 @@ static int op_symlink(const char *src, const char *dest)
goto out2;
}
- ret = check_inum_access(ff, parent, A_OK | W_OK);
+ ret = fuse4fs_inum_access(ff, parent, A_OK | W_OK);
if (ret)
goto out2;
@@ -2433,7 +2436,7 @@ static int op_rename(const char *from, const char *to,
FUSE4FS_CHECK_CONTEXT(ff);
dbg_printf(ff, "%s: renaming %s to %s\n", __func__, from, to);
fs = fuse4fs_start(ff);
- if (!fs_can_allocate(ff, 5)) {
+ if (!fuse4fs_can_allocate(ff, 5)) {
ret = -ENOSPC;
goto out;
}
@@ -2459,12 +2462,12 @@ static int op_rename(const char *from, const char *to,
goto out;
}
- ret = check_inum_access(ff, from_ino, W_OK);
+ ret = fuse4fs_inum_access(ff, from_ino, W_OK);
if (ret)
goto out;
if (to_ino) {
- ret = check_inum_access(ff, to_ino, W_OK);
+ ret = fuse4fs_inum_access(ff, to_ino, W_OK);
if (ret)
goto out;
}
@@ -2502,7 +2505,7 @@ static int op_rename(const char *from, const char *to,
goto out2;
}
- ret = check_inum_access(ff, from_dir_ino, W_OK);
+ ret = fuse4fs_inum_access(ff, from_dir_ino, W_OK);
if (ret)
goto out2;
@@ -2527,7 +2530,7 @@ static int op_rename(const char *from, const char *to,
goto out2;
}
- ret = check_inum_access(ff, to_dir_ino, W_OK);
+ ret = fuse4fs_inum_access(ff, to_dir_ino, W_OK);
if (ret)
goto out2;
@@ -2674,7 +2677,7 @@ static int op_link(const char *src, const char *dest)
*node_name = 0;
fs = fuse4fs_start(ff);
- if (!fs_can_allocate(ff, 2)) {
+ if (!fuse4fs_can_allocate(ff, 2)) {
ret = -ENOSPC;
goto out2;
}
@@ -2687,7 +2690,7 @@ static int op_link(const char *src, const char *dest)
goto out2;
}
- ret = check_inum_access(ff, parent, A_OK | W_OK);
+ ret = fuse4fs_inum_access(ff, parent, A_OK | W_OK);
if (ret)
goto out2;
@@ -2703,7 +2706,7 @@ static int op_link(const char *src, const char *dest)
goto out2;
}
- ret = check_iflags_access(ff, ino, EXT2_INODE(&inode), W_OK);
+ ret = fuse4fs_iflags_access(ff, ino, EXT2_INODE(&inode), W_OK);
if (ret)
goto out2;
@@ -2743,7 +2746,7 @@ static int op_link(const char *src, const char *dest)
}
/* Obtain group ids of the process that sent us a command(?) */
-static int get_req_groups(struct fuse4fs *ff, gid_t **gids, size_t *nr_gids)
+static int fuse4fs_get_groups(struct fuse4fs *ff, gid_t **gids, size_t *nr_gids)
{
ext2_filsys fs = ff->fs;
errcode_t err;
@@ -2788,8 +2791,8 @@ static int get_req_groups(struct fuse4fs *ff, gid_t **gids, size_t *nr_gids)
* that initiated the fuse request? Returns 1 for yes, 0 for no, or a negative
* errno.
*/
-static int in_file_group(struct fuse_context *ctxt,
- const struct ext2_inode_large *inode)
+static int fuse4fs_in_file_group(struct fuse_context *ctxt,
+ const struct ext2_inode_large *inode)
{
struct fuse4fs *ff = fuse4fs_get();
gid_t *gids = NULL;
@@ -2797,7 +2800,7 @@ static int in_file_group(struct fuse_context *ctxt,
gid_t gid = inode_gid(*inode);
int ret;
- ret = get_req_groups(ff, &gids, &nr_gids);
+ ret = fuse4fs_get_groups(ff, &gids, &nr_gids);
if (ret == -ENOENT) {
/* magic return code for "could not get caller group info" */
return ctxt->gid == inode_gid(*inode);
@@ -2840,11 +2843,11 @@ static int op_chmod(const char *path, mode_t mode, struct fuse_file_info *fi)
goto out;
}
- ret = check_iflags_access(ff, ino, EXT2_INODE(&inode), W_OK);
+ ret = fuse4fs_iflags_access(ff, ino, EXT2_INODE(&inode), W_OK);
if (ret)
goto out;
- if (want_check_owner(ff, ctxt) && ctxt->uid != inode_uid(inode)) {
+ if (fuse4fs_want_check_owner(ff, ctxt) && ctxt->uid != inode_uid(inode)) {
ret = -EPERM;
goto out;
}
@@ -2854,8 +2857,8 @@ static int op_chmod(const char *path, mode_t mode, struct fuse_file_info *fi)
* of the user's groups, but FUSE only tells us about the primary
* group.
*/
- if (!is_superuser(ff, ctxt)) {
- ret = in_file_group(ctxt, &inode);
+ if (!fuse4fs_is_superuser(ff, ctxt)) {
+ ret = fuse4fs_in_file_group(ctxt, &inode);
if (ret < 0)
goto out;
@@ -2909,14 +2912,14 @@ static int op_chown(const char *path, uid_t owner, gid_t group,
goto out;
}
- ret = check_iflags_access(ff, ino, EXT2_INODE(&inode), W_OK);
+ ret = fuse4fs_iflags_access(ff, ino, EXT2_INODE(&inode), W_OK);
if (ret)
goto out;
/* FUSE seems to feed us ~0 to mean "don't change" */
if (owner != (uid_t) ~0) {
/* Only root gets to change UID. */
- if (want_check_owner(ff, ctxt) &&
+ if (fuse4fs_want_check_owner(ff, ctxt) &&
!(inode_uid(inode) == ctxt->uid && owner == ctxt->uid)) {
ret = -EPERM;
goto out;
@@ -2926,7 +2929,7 @@ static int op_chown(const char *path, uid_t owner, gid_t group,
if (group != (gid_t) ~0) {
/* Only root or the owner get to change GID. */
- if (want_check_owner(ff, ctxt) &&
+ if (fuse4fs_want_check_owner(ff, ctxt) &&
inode_uid(inode) != ctxt->uid) {
ret = -EPERM;
goto out;
@@ -3036,7 +3039,7 @@ static int op_truncate(const char *path, off_t len, struct fuse_file_info *fi)
goto out;
dbg_printf(ff, "%s: ino=%d len=%jd\n", __func__, ino, (intmax_t) len);
- ret = check_inum_access(ff, ino, W_OK);
+ ret = fuse4fs_inum_access(ff, ino, W_OK);
if (ret)
goto out;
@@ -3118,7 +3121,7 @@ static int __op_open(struct fuse4fs *ff, const char *path,
}
dbg_printf(ff, "%s: ino=%d\n", __func__, file->ino);
- ret = check_inum_access(ff, file->ino, check);
+ ret = fuse4fs_inum_access(ff, file->ino, check);
if (ret) {
/*
* In a regular (Linux) fs driver, the kernel will open
@@ -3130,7 +3133,7 @@ static int __op_open(struct fuse4fs *ff, const char *path,
* also employ undocumented hacks (see above).
*/
if (check == R_OK) {
- ret = check_inum_access(ff, file->ino, X_OK);
+ ret = fuse4fs_inum_access(ff, file->ino, X_OK);
if (ret)
goto out;
} else
@@ -3239,7 +3242,7 @@ static int op_write(const char *path EXT2FS_ATTR((unused)),
goto out;
}
- if (!fs_can_allocate(ff, FUSE4FS_B_TO_FSB(ff, len))) {
+ if (!fuse4fs_can_allocate(ff, FUSE4FS_B_TO_FSB(ff, len))) {
ret = -ENOSPC;
goto out;
}
@@ -3439,11 +3442,11 @@ static int op_getxattr(const char *path, const char *key, char *value,
}
dbg_printf(ff, "%s: ino=%d name=%s\n", __func__, ino, key);
- ret = check_inum_access(ff, ino, R_OK);
+ ret = fuse4fs_inum_access(ff, ino, R_OK);
if (ret)
goto out;
- ret = __getxattr(ff, ino, key, &ptr, &plen);
+ ret = fuse4fs_getxattr(ff, ino, key, &ptr, &plen);
if (ret)
goto out;
@@ -3509,7 +3512,7 @@ static int op_listxattr(const char *path, char *names, size_t len)
}
dbg_printf(ff, "%s: ino=%d\n", __func__, ino);
- ret = check_inum_access(ff, ino, R_OK);
+ ret = fuse4fs_inum_access(ff, ino, R_OK);
if (ret)
goto out;
@@ -3590,7 +3593,7 @@ static int op_setxattr(const char *path EXT2FS_ATTR((unused)),
}
dbg_printf(ff, "%s: ino=%d name=%s\n", __func__, ino, key);
- ret = check_inum_access(ff, ino, W_OK);
+ ret = fuse4fs_inum_access(ff, ino, W_OK);
if (ret == -EACCES) {
ret = -EPERM;
goto out;
@@ -3679,7 +3682,7 @@ static int op_removexattr(const char *path, const char *key)
goto out;
}
- if (!fs_can_allocate(ff, 1)) {
+ if (!fuse4fs_can_allocate(ff, 1)) {
ret = -ENOSPC;
goto out;
}
@@ -3691,7 +3694,7 @@ static int op_removexattr(const char *path, const char *key)
}
dbg_printf(ff, "%s: ino=%d name=%s\n", __func__, ino, key);
- ret = check_inum_access(ff, ino, W_OK);
+ ret = fuse4fs_inum_access(ff, ino, W_OK);
if (ret)
goto out;
@@ -3878,7 +3881,7 @@ static int op_access(const char *path, int mask)
goto out;
}
- ret = check_inum_access(ff, ino, mask);
+ ret = fuse4fs_inum_access(ff, ino, mask);
if (ret)
goto out;
@@ -3918,7 +3921,7 @@ static int op_create(const char *path, mode_t mode, struct fuse_file_info *fp)
*node_name = 0;
fs = fuse4fs_start(ff);
- if (!fs_can_allocate(ff, 1)) {
+ if (!fuse4fs_can_allocate(ff, 1)) {
ret = -ENOSPC;
goto out2;
}
@@ -3930,7 +3933,7 @@ static int op_create(const char *path, mode_t mode, struct fuse_file_info *fp)
goto out2;
}
- ret = check_inum_access(ff, parent, A_OK | W_OK);
+ ret = fuse4fs_inum_access(ff, parent, A_OK | W_OK);
if (ret)
goto out2;
@@ -3997,7 +4000,7 @@ static int op_create(const char *path, mode_t mode, struct fuse_file_info *fp)
ext2fs_inode_alloc_stats2(fs, child, 1, 0);
- ret = propagate_default_acls(ff, parent, child);
+ ret = fuse4fs_propagate_default_acls(ff, parent, child);
if (ret)
goto out2;
@@ -4045,7 +4048,7 @@ static int op_utimens(const char *path, const struct timespec ctv[2],
*/
if (ctv[0].tv_nsec == UTIME_NOW && ctv[1].tv_nsec == UTIME_NOW)
access |= A_OK;
- ret = check_inum_access(ff, ino, access);
+ ret = fuse4fs_inum_access(ff, ino, access);
if (ret)
goto out;
@@ -4130,7 +4133,7 @@ static int ioctl_setflags(struct fuse4fs *ff, struct fuse4fs_file_handle *fh,
if (err)
return translate_error(fs, fh->ino, err);
- if (want_check_owner(ff, ctxt) && inode_uid(inode) != ctxt->uid)
+ if (fuse4fs_want_check_owner(ff, ctxt) && inode_uid(inode) != ctxt->uid)
return -EPERM;
ret = set_iflags(&inode, flags);
@@ -4179,7 +4182,7 @@ static int ioctl_setversion(struct fuse4fs *ff, struct fuse4fs_file_handle *fh,
if (err)
return translate_error(fs, fh->ino, err);
- if (want_check_owner(ff, ctxt) && inode_uid(inode) != ctxt->uid)
+ if (fuse4fs_want_check_owner(ff, ctxt) && inode_uid(inode) != ctxt->uid)
return -EPERM;
inode.i_generation = generation;
@@ -4278,7 +4281,7 @@ static int ioctl_fssetxattr(struct fuse4fs *ff, struct fuse4fs_file_handle *fh,
if (err)
return translate_error(fs, fh->ino, err);
- if (want_check_owner(ff, ctxt) && inode_uid(inode) != ctxt->uid)
+ if (fuse4fs_want_check_owner(ff, ctxt) && inode_uid(inode) != ctxt->uid)
return -EPERM;
ret = set_iflags(&inode, flags);
@@ -4399,7 +4402,7 @@ static int ioctl_shutdown(struct fuse4fs *ff, struct fuse4fs_file_handle *fh,
struct fuse_context *ctxt = fuse_get_context();
ext2_filsys fs = ff->fs;
- if (!is_superuser(ff, ctxt))
+ if (!fuse4fs_is_superuser(ff, ctxt))
return -EPERM;
err_printf(ff, "%s.\n", _("shut down requested"));
@@ -4518,7 +4521,7 @@ static int fuse4fs_allocate_range(struct fuse4fs *ff,
(unsigned long long)len,
(unsigned long long)start,
(unsigned long long)end);
- if (!fs_can_allocate(ff, FUSE4FS_B_TO_FSB(ff, len)))
+ if (!fuse4fs_can_allocate(ff, FUSE4FS_B_TO_FSB(ff, len)))
return -ENOSPC;
err = fuse4fs_read_inode(fs, fh->ino, &inode);
@@ -4561,9 +4564,9 @@ static int fuse4fs_allocate_range(struct fuse4fs *ff,
return err;
}
-static errcode_t clean_block_middle(struct fuse4fs *ff, ext2_ino_t ino,
- struct ext2_inode_large *inode,
- off_t offset, off_t len, char **buf)
+static errcode_t fuse4fs_zero_middle(struct fuse4fs *ff, ext2_ino_t ino,
+ struct ext2_inode_large *inode,
+ off_t offset, off_t len, char **buf)
{
ext2_filsys fs = ff->fs;
blk64_t blk;
@@ -4597,9 +4600,9 @@ static errcode_t clean_block_middle(struct fuse4fs *ff, ext2_ino_t ino,
return io_channel_write_blk64(fs->io, blk, 1, *buf);
}
-static errcode_t clean_block_edge(struct fuse4fs *ff, ext2_ino_t ino,
- struct ext2_inode_large *inode, off_t offset,
- int clean_before, char **buf)
+static errcode_t fuse4fs_zero_edge(struct fuse4fs *ff, ext2_ino_t ino,
+ struct ext2_inode_large *inode, off_t offset,
+ int clean_before, char **buf)
{
ext2_filsys fs = ff->fs;
blk64_t blk;
@@ -4690,13 +4693,13 @@ static int fuse4fs_punch_range(struct fuse4fs *ff,
/* Zero everything before the first block and after the last block */
if (FUSE4FS_B_TO_FSBT(ff, offset) == FUSE4FS_B_TO_FSBT(ff, offset + len))
- err = clean_block_middle(ff, fh->ino, &inode, offset,
+ err = fuse4fs_zero_middle(ff, fh->ino, &inode, offset,
len, &buf);
else {
- err = clean_block_edge(ff, fh->ino, &inode, offset, 0, &buf);
+ err = fuse4fs_zero_edge(ff, fh->ino, &inode, offset, 0, &buf);
if (!err)
- err = clean_block_edge(ff, fh->ino, &inode,
- offset + len, 1, &buf);
+ err = fuse4fs_zero_edge(ff, fh->ino, &inode,
+ offset + len, 1, &buf);
}
if (buf)
ext2fs_free_mem(&buf);
next prev parent reply other threads:[~2025-08-21 1:08 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 0:37 [RFC v4] fuse: use fs-iomap for better performance so we can containerize ext4 Darrick J. Wong
2025-08-21 0:49 ` [PATCHSET RFC v4 1/6] fuse4fs: fork a low level fuse server Darrick J. Wong
2025-08-21 1:08 ` [PATCH 01/20] fuse2fs: port fuse2fs to lowlevel libfuse API Darrick J. Wong
2025-08-21 1:08 ` [PATCH 02/20] fuse4fs: drop fuse 2.x support code Darrick J. Wong
2025-08-21 1:08 ` Darrick J. Wong [this message]
2025-08-21 1:08 ` [PATCH 04/20] fuse4fs: convert to low level API Darrick J. Wong
2025-08-21 1:09 ` [PATCH 05/20] libsupport: port the kernel list.h to libsupport Darrick J. Wong
2025-08-21 1:09 ` [PATCH 06/20] libsupport: add a cache Darrick J. Wong
2025-08-21 1:09 ` [PATCH 07/20] cache: disable debugging Darrick J. Wong
2025-08-21 1:09 ` [PATCH 08/20] cache: use modern list iterator macros Darrick J. Wong
2025-08-21 1:10 ` [PATCH 09/20] cache: embed struct cache in the owner Darrick J. Wong
2025-08-21 1:10 ` [PATCH 10/20] cache: pass cache pointer to callbacks Darrick J. Wong
2025-08-21 1:10 ` [PATCH 11/20] cache: pass a private data pointer through cache_walk Darrick J. Wong
2025-08-21 1:11 ` [PATCH 12/20] cache: add a helper to grab a new refcount for a cache_node Darrick J. Wong
2025-08-21 1:11 ` [PATCH 13/20] cache: return results of a cache flush Darrick J. Wong
2025-08-21 1:11 ` [PATCH 14/20] cache: add a "get only if incore" flag to cache_node_get Darrick J. Wong
2025-08-21 1:11 ` [PATCH 15/20] cache: support gradual expansion Darrick J. Wong
2025-08-21 1:12 ` [PATCH 16/20] cache: implement automatic shrinking Darrick J. Wong
2025-08-21 1:12 ` [PATCH 17/20] fuse4fs: add cache to track open files Darrick J. Wong
2025-08-21 1:12 ` [PATCH 18/20] fuse4fs: use the orphaned inode list Darrick J. Wong
2025-08-21 1:12 ` [PATCH 19/20] fuse4fs: implement FUSE_TMPFILE Darrick J. Wong
2025-08-21 1:13 ` [PATCH 20/20] fuse4fs: create incore reverse orphan list Darrick J. Wong
2025-08-21 0:49 ` [PATCHSET RFC v4 2/6] libext2fs: refactoring for fuse2fs iomap support Darrick J. Wong
2025-08-21 1:13 ` [PATCH 01/10] libext2fs: make it possible to extract the fd from an IO manager Darrick J. Wong
2025-08-21 1:13 ` [PATCH 02/10] libext2fs: always fsync the device when flushing the cache Darrick J. Wong
2025-08-21 1:13 ` [PATCH 03/10] libext2fs: always fsync the device when closing the unix IO manager Darrick J. Wong
2025-08-21 1:14 ` [PATCH 04/10] libext2fs: only fsync the unix fd if we wrote to the device Darrick J. Wong
2025-08-21 1:14 ` [PATCH 05/10] libext2fs: invalidate cached blocks when freeing them Darrick J. Wong
2025-08-21 1:14 ` [PATCH 06/10] libext2fs: only flush affected blocks in unix_write_byte Darrick J. Wong
2025-08-21 1:14 ` [PATCH 07/10] libext2fs: allow unix_write_byte when the write would be aligned Darrick J. Wong
2025-08-21 1:15 ` [PATCH 08/10] libext2fs: allow clients to ask to write full superblocks Darrick J. Wong
2025-08-21 1:15 ` [PATCH 09/10] libext2fs: allow callers to disallow I/O to file data blocks Darrick J. Wong
2025-08-21 1:15 ` [PATCH 10/10] libext2fs: add posix advisory locking to the unix IO manager Darrick J. Wong
2025-08-21 0:49 ` [PATCHSET RFC v4 3/6] fuse2fs: use fuse iomap data paths for better file I/O performance Darrick J. Wong
2025-08-21 1:15 ` [PATCH 01/19] fuse2fs: implement bare minimum iomap for file mapping reporting Darrick J. Wong
2025-08-21 1:16 ` [PATCH 02/19] fuse2fs: add iomap= mount option Darrick J. Wong
2025-08-21 1:16 ` [PATCH 03/19] fuse2fs: implement iomap configuration Darrick J. Wong
2025-08-21 1:16 ` [PATCH 04/19] fuse2fs: register block devices for use with iomap Darrick J. Wong
2025-08-21 1:17 ` [PATCH 05/19] fuse2fs: implement directio file reads Darrick J. Wong
2025-08-21 1:17 ` [PATCH 06/19] fuse2fs: add extent dump function for debugging Darrick J. Wong
2025-08-21 1:17 ` [PATCH 07/19] fuse2fs: implement direct write support Darrick J. Wong
2025-08-21 1:17 ` [PATCH 08/19] fuse2fs: turn on iomap for pagecache IO Darrick J. Wong
2025-08-21 1:18 ` [PATCH 09/19] fuse2fs: don't zero bytes in punch hole Darrick J. Wong
2025-08-21 1:18 ` [PATCH 10/19] fuse2fs: don't do file data block IO when iomap is enabled Darrick J. Wong
2025-08-21 1:18 ` [PATCH 11/19] fuse2fs: avoid fuseblk mode if fuse-iomap support is likely Darrick J. Wong
2025-08-21 1:18 ` [PATCH 12/19] fuse2fs: enable file IO to inline data files Darrick J. Wong
2025-08-21 1:19 ` [PATCH 13/19] fuse2fs: set iomap-related inode flags Darrick J. Wong
2025-08-21 1:19 ` [PATCH 14/19] fuse2fs: add strictatime/lazytime mount options Darrick J. Wong
2025-08-21 1:19 ` [PATCH 15/19] fuse2fs: configure block device block size Darrick J. Wong
2025-08-21 1:19 ` [PATCH 16/19] fuse4fs: don't use inode number translation when possible Darrick J. Wong
2025-08-21 1:20 ` [PATCH 17/19] fuse4fs: separate invalidation Darrick J. Wong
2025-08-21 1:20 ` [PATCH 18/19] fuse2fs: implement statx Darrick J. Wong
2025-08-21 1:20 ` [PATCH 19/19] fuse2fs: enable atomic writes Darrick J. Wong
2025-08-21 0:50 ` [PATCHSET RFC v4 4/6] fuse2fs: use fuse iomap data paths for better file I/O performance Darrick J. Wong
2025-08-21 1:20 ` [PATCH 1/2] fuse2fs: enable caching of iomaps Darrick J. Wong
2025-08-21 1:21 ` [PATCH 2/2] fuse2fs: be smarter about caching iomaps Darrick J. Wong
2025-08-21 0:50 ` [PATCHSET RFC v4 5/6] fuse2fs: handle timestamps and ACLs correctly when iomap is enabled Darrick J. Wong
2025-08-21 1:21 ` [PATCH 1/8] fuse2fs: skip permission checking on utimens " Darrick J. Wong
2025-08-21 1:21 ` [PATCH 2/8] fuse2fs: let the kernel tell us about acl/mode updates Darrick J. Wong
2025-08-21 1:21 ` [PATCH 3/8] fuse2fs: better debugging for file mode updates Darrick J. Wong
2025-08-21 1:22 ` [PATCH 4/8] fuse2fs: debug timestamp updates Darrick J. Wong
2025-08-21 1:22 ` [PATCH 5/8] fuse2fs: use coarse timestamps for iomap mode Darrick J. Wong
2025-08-21 1:22 ` [PATCH 6/8] fuse2fs: add tracing for retrieving timestamps Darrick J. Wong
2025-08-21 1:23 ` [PATCH 7/8] fuse2fs: enable syncfs Darrick J. Wong
2025-08-21 1:23 ` [PATCH 8/8] fuse2fs: skip the gdt write in op_destroy if syncfs is working Darrick J. Wong
2025-08-21 0:50 ` [PATCHSET RFC v4 6/6] fuse2fs: improve block and inode caching Darrick J. Wong
2025-08-21 1:23 ` [PATCH 1/6] libsupport: add caching IO manager Darrick J. Wong
2025-08-21 1:23 ` [PATCH 2/6] iocache: add the actual buffer cache Darrick J. Wong
2025-08-21 1:24 ` [PATCH 3/6] iocache: bump buffer mru priority every 50 accesses Darrick J. Wong
2025-08-21 1:24 ` [PATCH 4/6] fuse2fs: enable caching IO manager Darrick J. Wong
2025-08-21 1:24 ` [PATCH 5/6] fuse2fs: increase inode cache size Darrick J. Wong
2025-08-21 1:24 ` [PATCH 6/6] libext2fs: improve caching for inodes Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175573712861.20753.12678836494772235653.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=John@groves.net \
--cc=amir73il@gmail.com \
--cc=bernd@bsbernd.com \
--cc=joannelkoong@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neal@gompa.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox