From: "Darrick J. Wong" <djwong@kernel.org>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 11/12] fuse2fs: work around EBUSY discard returns from dm-thinp
Date: Mon, 15 Sep 2025 15:40:35 -0700 [thread overview]
Message-ID: <175797569817.245695.5933808486760481103.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <175797569564.245695.4628729304068635201.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
generic/500 has this interesting failure mode when fuse2fs is running in
fuseblk mode:
--- /run/fstests/bin/tests/generic/500.out 2025-07-15 14:45:15.092576090 -0700
+++ /var/tmp/fstests/generic/500.out.bad 2025-09-05 15:09:35.211499883 -0700
@@ -1,2 +1,22 @@
QA output created by 500
+fstrim: /opt: FITRIM ioctl failed: Device or resource busy
Apparently you can overwhelm dm-thinp with a large number of discard
requests, at which point it starts returning EBUSY. This is unexpected
behavior but let's mask that off because discard is advisory anyways.
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
misc/fuse2fs.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c
index 7ec7875d9108a2..c09b2aa04c02fb 100644
--- a/misc/fuse2fs.c
+++ b/misc/fuse2fs.c
@@ -4038,6 +4038,14 @@ static int ioctl_fitrim(struct fuse2fs *ff, struct fuse2fs_file_handle *fh,
if (b - start >= minlen) {
err = io_channel_discard(fs->io, start, b - start);
+ if (err == EBUSY) {
+ /*
+ * Apparently dm-thinp can return EBUSY when
+ * it's too busy deallocating thinp units to
+ * deallocate more. Swallow these errors.
+ */
+ err = 0;
+ }
if (err)
return translate_error(fs, fh->ino, err);
cleared += b - start;
next prev parent reply other threads:[~2025-09-15 22:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 22:37 [PATCHSET 1/2] fuse2fs: round 5 bug fixes Darrick J. Wong
2025-09-15 22:37 ` [PATCH 01/12] libext2fs: use F_GETFL, not F_GETFD, in unixfd_open Darrick J. Wong
2025-09-15 22:38 ` [PATCH 02/12] libext2fs: don't look for O_EXCL in the F_GETFL output Darrick J. Wong
2025-09-15 22:38 ` [PATCH 03/12] fuse2fs: update manpage Darrick J. Wong
2025-09-15 22:38 ` [PATCH 04/12] fuse2fs: quiet down EXT2_ET_RO_FILSYS errors Darrick J. Wong
2025-09-15 22:39 ` [PATCH 05/12] fuse2fs: free global_fs after a failed ext2fs_close call Darrick J. Wong
2025-10-06 21:23 ` Darrick J. Wong
2025-09-15 22:39 ` [PATCH 06/12] fuse2fs: fix memory corruption when parsing mount options Darrick J. Wong
2025-10-10 15:30 ` Dave Dykstra
2025-09-15 22:39 ` [PATCH 07/12] fuse2fs: fix fssetxattr flags updates Darrick J. Wong
2025-09-15 22:39 ` [PATCH 08/12] fuse2fs: fix default acls propagating to non-dir children Darrick J. Wong
2025-09-15 22:40 ` [PATCH 09/12] fuse2fs: don't update atime when reading executable file content Darrick J. Wong
2025-09-15 22:40 ` [PATCH 10/12] fuse2fs: fix in_file_group missing the primary process gid Darrick J. Wong
2025-09-15 22:40 ` Darrick J. Wong [this message]
2025-09-15 22:40 ` [PATCH 12/12] fuse2fs: check free space when creating a symlink Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175797569817.245695.5933808486760481103.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox