Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

Andrew Morton
2006-09-14T03:38:17Z

On Wed, 13 Sep 2006 15:25:19 -0500
Dave Kleikamp <shaggy@austin.ibm.com> wrote:

> > +void journal_do_submit_data(struct buffer_head **wbuf, int bufs)
>
> Is there any reason this couldn't be static?

Nope.

> > +{
> > + int i;
> > +
> > + for (i = 0; i < bufs; i++) {
> > + wbuf[i]->b_end_io = end_buffer_write_sync;
> > + /* We use-up our safety reference in submit_bh() */
> > + submit_bh(WRITE, wbuf[i]);
> > + }
> > +}
>
> I'm rebasing the ext4 work on the latest -mm tree and would like to
> avoid renaming this function in the jbd2 clone.

<edits the diff>