From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@suse.de>, Badari Pulavarty <pbadari@us.ibm.com>,
Jan Kara <jack@suse.cz>,
torvalds@osdl.org, stable@kernel.org,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [patch 003/152] jbd: fix commit of ordered data buffers
Date: Fri, 29 Sep 2006 23:22:27 +0200 [thread overview]
Message-ID: <20060929212227.GA14030@elte.hu> (raw)
In-Reply-To: <20060929132057.3039bac8.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> + if (cpu_isset(cpu, backtrace_mask)) {
> + cpu_clear(cpu, backtrace_mask);
> + printk("NMI backtrace for cpu %d\n", cpu);
> + dump_stack();
> + }
yeah. There's just one issue: this will mix all the printks from all
CPUs at once (the NMIs if IO-APIC triggered fire at once). The way i
solved this was to add a private spinlock around the printk and
dump_stack().
Ingo
next prev parent reply other threads:[~2006-09-29 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200609260630.k8Q6UrvQ011999@shell0.pdx.osdl.net>
[not found] ` <451C4DDE.60307@us.ibm.com>
[not found] ` <20060929090253.GA17124@atrey.karlin.mff.cuni.cz>
2006-09-29 16:11 ` [patch 003/152] jbd: fix commit of ordered data buffers Badari Pulavarty
2006-09-29 19:20 ` Andrew Morton
2006-09-29 19:18 ` Ingo Molnar
2006-09-29 19:54 ` Andi Kleen
2006-09-29 20:20 ` Andrew Morton
2006-09-29 21:22 ` Ingo Molnar [this message]
2006-09-29 21:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060929212227.GA14030@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox