From: Andreas Dilger <adilger@clusterfs.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH, E2FSPROGS] On-disk format definition group desciptor checksums
Date: Wed, 18 Oct 2006 13:28:37 -0600 [thread overview]
Message-ID: <20061018192837.GE3509@schatzie.adilger.int> (raw)
In-Reply-To: <E1Ga4pe-0004rB-Cj@candygram.thunk.org>
On Oct 18, 2006 02:23 -0400, Theodore Ts'o wrote:
> On-disk format definition for group descriptor checksums
>
> - EXT4_FEATURE_RO_COMPAT_GDT_CSUM (0x0010?) - store a crc16 checksum in
> the group descriptor (s_uuid[16] | __u32 group | ext3_group_desc
> (excluding gd_checksum itself)). This allows the kernel to more safely
> manage UNINIT groups.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Looks good to me.
> Index: e2fsprogs/lib/ext2fs/ext2_fs.h
> ===================================================================
> --- e2fsprogs.orig/lib/ext2fs/ext2_fs.h 2006-10-18 02:20:35.000000000 -0400
> +++ e2fsprogs/lib/ext2fs/ext2_fs.h 2006-10-18 02:20:41.000000000 -0400
> @@ -144,7 +144,9 @@
> __u16 bg_free_inodes_count; /* Free inodes count */
> __u16 bg_used_dirs_count; /* Directories count */
> __u16 bg_flags;
> - __u32 bg_reserved[3];
> + __u32 bg_reserved[2];
> + __u16 bg_itable_unused; /* Unused inodes count */
> + __u16 bg_checksum; /* crc16(s_uuid+grouo_num+group_desc)*/
> };
>
> struct ext4_group_desc
> @@ -601,6 +603,7 @@
> #define EXT2_FEATURE_RO_COMPAT_LARGE_FILE 0x0002
> /* #define EXT2_FEATURE_RO_COMPAT_BTREE_DIR 0x0004 not used */
> #define EXT4_FEATURE_RO_COMPAT_HUGE_FILE 0x0008
> +#define EXT4_FEATURE_RO_COMPAT_GDT_CSUM 0x0010
>
> #define EXT2_FEATURE_INCOMPAT_COMPRESSION 0x0001
> #define EXT2_FEATURE_INCOMPAT_FILETYPE 0x0002
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2006-10-18 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 6:23 [PATCH, E2FSPROGS] On-disk format definition group desciptor checksums Theodore Ts'o
2006-10-18 19:28 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018192837.GE3509@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox