public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@clusterfs.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH, E2FSPROGS] On-disk format for large number of subdirectors
Date: Wed, 18 Oct 2006 13:29:28 -0600	[thread overview]
Message-ID: <20061018192928.GF3509@schatzie.adilger.int> (raw)
In-Reply-To: <E1Ga4qP-0004wH-85@candygram.thunk.org>

On Oct 18, 2006  02:24 -0400, Theodore Ts'o wrote:
> On-disk format for large number of subdirectories
> 
> - EXT4_FEATURE_RO_COMPAT_DIR_NLINK (0x0020?) - allow directories to have
>   > 65000 subdirectories (i_nlinks) by setting i_nlinks = 1 for such
>   directories.  RO_COMPAT protects old filesystems from unlinking such
>   directories incorrectly and losing all files therein.  
> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

Looks good.  Will try to get a new patch out with this support.

> Index: e2fsprogs/lib/ext2fs/ext2_fs.h
> ===================================================================
> --- e2fsprogs.orig/lib/ext2fs/ext2_fs.h	2006-10-18 01:42:48.000000000 -0400
> +++ e2fsprogs/lib/ext2fs/ext2_fs.h	2006-10-18 01:49:51.000000000 -0400
> @@ -71,7 +71,7 @@
>  /*
>   * Maximal count of links to a file
>   */
> -#define EXT2_LINK_MAX		32000
> +#define EXT2_LINK_MAX		65000
>  
>  /*
>   * Macro-instructions used to manage several block sizes
> @@ -606,6 +606,7 @@
>  /* #define EXT2_FEATURE_RO_COMPAT_BTREE_DIR	0x0004 not used */
>  #define EXT4_FEATURE_RO_COMPAT_HUGE_FILE	0x0008
>  #define EXT4_FEATURE_RO_COMPAT_GDT_CSUM		0x0010
> +#define EXT4_FEATURE_RO_COMPAT_DIR_NLINK	0x0020
>  
>  #define EXT2_FEATURE_INCOMPAT_COMPRESSION	0x0001
>  #define EXT2_FEATURE_INCOMPAT_FILETYPE		0x0002

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

      reply	other threads:[~2006-10-18 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-18  6:24 [PATCH, E2FSPROGS] On-disk format for large number of subdirectors Theodore Ts'o
2006-10-18 19:29 ` Andreas Dilger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061018192928.GF3509@schatzie.adilger.int \
    --to=adilger@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox