From: Andreas Dilger <adilger@clusterfs.com>
To: Eric Sandeen <esandeen@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH/RFC] - make ext3 more robust in the face of filesystem corruption
Date: Thu, 19 Oct 2006 01:35:18 -0600 [thread overview]
Message-ID: <20061019073518.GN3509@schatzie.adilger.int> (raw)
In-Reply-To: <4536C642.5020301@redhat.com>
On Oct 18, 2006 19:26 -0500, Eric Sandeen wrote:
> >Well, it would also be possible to look into inode->i_blocks to see what
> >blocks exist past this offset, but that is complicated by the introduction
> > <eom>
> introduction of ...? :)
Sorry - introduction of extents. So we can't just look into the i_blocks
{d,t,}indirect blocks to work out the maximum reasonable size for an inode
without adding decoding of extents into this code. Maybe if "SEEK_DATA"
is added to ext3 (patch was proposed this past week) then we could seek
past the hole efficiently. For now I'm happy to assume i_blocks * 512 is
a safe upper limit on the file size.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2006-10-19 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 21:11 [PATCH/RFC] - make ext3 more robust in the face of filesystem corruption Eric Sandeen
2006-10-18 21:40 ` Andreas Dilger
2006-10-18 21:56 ` Eric Sandeen
2006-10-18 22:24 ` Andreas Dilger
2006-10-19 0:26 ` Eric Sandeen
2006-10-19 7:35 ` Andreas Dilger [this message]
2006-10-19 16:04 ` Eric Sandeen
2006-10-19 22:43 ` Eric Sandeen
2006-10-20 3:50 ` Andreas Dilger
2006-10-20 4:00 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019073518.GN3509@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=esandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox