From: akpm@osdl.org
To: mm-commits@vger.kernel.org
Cc: cmm@us.ibm.com, hugh@veritas.com, linux-ext4@vger.kernel.org
Subject: + ext4-fix-reservation-extension.patch added to -mm tree
Date: Tue, 21 Nov 2006 09:13:48 -0800 [thread overview]
Message-ID: <200611211713.kALHDm6b031991@shell0.pdx.osdl.net> (raw)
The patch titled
ext4: fix reservation extension
has been added to the -mm tree. Its filename is
ext4-fix-reservation-extension.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: ext4: fix reservation extension
From: Mingming Cao <cmm@us.ibm.com>
Hugh Dickins wrote:
> Not found anything relevant, but I keep noticing these lines
> in ext2_try_to_allocate_with_rsv(), ext3 and ext4 similar:
>
> } else if (grp_goal > 0 &&
> (my_rsv->rsv_end - grp_goal + 1) < *count)
> try_to_extend_reservation(my_rsv, sb,
> *count-my_rsv->rsv_end + grp_goal - 1);
>
> They're wrong, a no-op in most groups, aren't they? rsv_end is an
> absolute block number, whereas grp_goal is group-relative, so the
> calculation ought to bring in group_first_block? Or I'm confused.
>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
fs/ext4/balloc.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff -puN fs/ext2/balloc.c~ext4-fix-reservation-extension fs/ext2/balloc.c
diff -puN fs/ext3/balloc.c~ext4-fix-reservation-extension fs/ext3/balloc.c
diff -puN fs/ext4/balloc.c~ext4-fix-reservation-extension fs/ext4/balloc.c
--- a/fs/ext4/balloc.c~ext4-fix-reservation-extension
+++ a/fs/ext4/balloc.c
@@ -1324,10 +1324,14 @@ ext4_try_to_allocate_with_rsv(struct sup
if (!goal_in_my_reservation(&my_rsv->rsv_window,
grp_goal, group, sb))
grp_goal = -1;
- } else if (grp_goal > 0 &&
- (my_rsv->rsv_end-grp_goal+1) < *count)
- try_to_extend_reservation(my_rsv, sb,
- *count-my_rsv->rsv_end + grp_goal - 1);
+ } else if (grp_goal > 0) {
+ int curr = my_rsv->rsv_end -
+ (grp_goal + group_first_block) + 1;
+
+ if (curr < *count)
+ try_to_extend_reservation(my_rsv, sb,
+ *count - curr);
+ }
if ((my_rsv->rsv_start > group_last_block) ||
(my_rsv->rsv_end < group_first_block)) {
_
Patches currently in -mm which might be from cmm@us.ibm.com are
ext3-fix-reservation-extension.patch
ext4-fix-reservation-extension.patch
ext2-reservations.patch
ext2-fix-reservation-extension.patch
reply other threads:[~2006-11-21 17:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611211713.kALHDm6b031991@shell0.pdx.osdl.net \
--to=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).