* [PATCH] ext4: fix credit calculation in ext4_ext_calc_credits_for_insert
@ 2006-12-04 17:21 Johann Lombardi
0 siblings, 0 replies; only message in thread
From: Johann Lombardi @ 2006-12-04 17:21 UTC (permalink / raw)
To: linux-ext4; +Cc: akpm
Hello,
The patch below fixes a nit in ext4_ext_calc_credits_for_insert().
Besides, credits for the new root are already added in the index split
accounting.
Johann
Signed-off-by: Johann Lombardi <johann.lombardi@bull.net>
Signed-off-by: Alex Tomas <alex@clusterfs.com>
---
Index: linux-2.6.19/fs/ext4/extents.c
===================================================================
--- linux-2.6.19.orig/fs/ext4/extents.c 2006-12-04 16:59:41.760257656 +0100
+++ linux-2.6.19/fs/ext4/extents.c 2006-12-04 17:04:35.566592304 +0100
@@ -1534,16 +1534,17 @@ int inline ext4_ext_calc_credits_for_ins
/*
* tree can be full, so it would need to grow in depth:
- * allocation + old root + new root
+ * we need one credit to modify old root, credits for
+ * new root will be added in split accounting
*/
- needed += 2 + 1 + 1;
+ needed += 1;
/*
* Index split can happen, we would need:
* allocate intermediate indexes (bitmap + group)
* + change two blocks at each level, but root (already included)
*/
- needed = (depth * 2) + (depth * 2);
+ needed += (depth * 2) + (depth * 2);
/* any allocation modifies superblock */
needed += 1;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-04 17:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-04 17:21 [PATCH] ext4: fix credit calculation in ext4_ext_calc_credits_for_insert Johann Lombardi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).