From: akpm@osdl.org
To: torvalds@osdl.org
Cc: akpm@osdl.org, bunk@stusta.de, linux-ext4@vger.kernel.org
Subject: [patch 201/354] ext4_ext_split(): remove dead code
Date: Wed, 06 Dec 2006 20:37:25 -0800 [thread overview]
Message-ID: <200612070437.kB74bPIj029669@shell0.pdx.osdl.net> (raw)
From: Adrian Bunk <bunk@stusta.de>
The Coverity checker noted that this was dead code, since in all places
above in this function, "err" is immediately checked.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
fs/ext4/extents.c | 3 ---
1 file changed, 3 deletions(-)
diff -puN fs/ext4/extents.c~ext4_ext_split-remove-dead-code fs/ext4/extents.c
--- a/fs/ext4/extents.c~ext4_ext_split-remove-dead-code
+++ a/fs/ext4/extents.c
@@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *hand
}
/* insert new index */
- if (err)
- goto cleanup;
-
err = ext4_ext_insert_index(handle, inode, path + at,
le32_to_cpu(border), newblock);
_
reply other threads:[~2006-12-07 4:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612070437.kB74bPIj029669@shell0.pdx.osdl.net \
--to=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-ext4@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).