linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 278/354] ext4 balloc: fix _with_rsv freeze
@ 2006-12-07  4:39 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2006-12-07  4:39 UTC (permalink / raw)
  To: torvalds; +Cc: akpm, hugh, cmm, linux-ext4

From: Hugh Dickins <hugh@veritas.com>

Port fix to the off-by-one in find_next_usable_block's memscan from ext2 to
ext4; but it didn't cause a serious problem for ext4 because the additional
ext4_test_allocatable check rescued it from the error.

[akpm@osdl.org: build fix]
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 fs/ext4/balloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/ext4/balloc.c~ext4-balloc-fix-_with_rsv-freeze fs/ext4/balloc.c
--- a/fs/ext4/balloc.c~ext4-balloc-fix-_with_rsv-freeze
+++ a/fs/ext4/balloc.c
@@ -747,7 +747,7 @@ find_next_usable_block(ext4_grpblk_t sta
 		here = 0;
 
 	p = ((char *)bh->b_data) + (here >> 3);
-	r = memscan(p, 0, (maxblocks - here + 7) >> 3);
+	r = memscan(p, 0, ((maxblocks + 7) >> 3) - (here >> 3));
 	next = (r - ((char *)bh->b_data)) << 3;
 
 	if (next < maxblocks && next >= start && ext4_test_allocatable(next, bh))
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-07  4:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-07  4:39 [patch 278/354] ext4 balloc: fix _with_rsv freeze akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).