From: Andreas Dilger <adilger@clusterfs.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Alexandre Ratchov <alexandre.ratchov@bull.net>,
linux-ext4@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: rfc: [patch] change attribute for ext3
Date: Thu, 14 Dec 2006 16:04:55 -0700 [thread overview]
Message-ID: <20061214230455.GN5937@schatzie.adilger.int> (raw)
In-Reply-To: <1166114889.20014.30.camel@lade.trondhjem.org>
On Dec 14, 2006 11:48 -0500, Trond Myklebust wrote:
> > The only requirement is that it be unique (assuming a file is never
> > modified 2^64 times). Clients can't compare them except for equality.
>
> The other requirement is that they be updated in more or less any
> situation where you would normally see a 'ctime' update. In other words
> any time when the file metadata or data changes, and any time when the
> ACL changes.
So, to confirm - if existing ext3 filesystems only had 32 bits for the
change attribute, but ext4 filesystems had 64 bits, would that be OK?
If the change attribute would wrap in rare cases, it would still satisfy
the inequality check, but the sequential update behaviour would be lost
for that one update and the client may unnecessarily flush its cache,
or in extremely rare cases NOT flush its cache (if it was disconnected
for exactly 2^32 updates).
If there is a hard requirement for 64-bit change attributes then this
wouldn't be possible without forcing a reformat and update to ext4
with large inodes.
> Yup. It is used to detect changes made on the NFS server itself
> (possibly by other NFS clients, possibly by local processes on the
> server), so that the client can flush out any stale cached data.
What API do you think would be good for getting the change attribute?
I was thinking using i_version for this would be appropriate, since
that is used for the same function already (internal revalidation of
an inode after a lock was dropped temporarily). It would need to be
extended to 64 bits in size (if you can convince the rest of the
kernel developers about this) or alternately an export_operations method
and the filesystem stores the 64-bit version in its inode_info?
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2006-12-14 23:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 16:42 rfc: [patch] change attribute for ext3 Alexandre Ratchov
2006-09-13 18:11 ` Trond Myklebust
2006-09-13 18:30 ` Alexandre Ratchov
2006-09-13 19:06 ` Trond Myklebust
2006-09-13 20:31 ` Randy.Dunlap
2006-09-14 9:23 ` Andreas Dilger
2006-09-14 13:48 ` Alexandre Ratchov
2006-11-14 22:17 ` Andreas Dilger
2006-11-24 0:23 ` Andreas Dilger
2006-11-28 19:00 ` J. Bruce Fields
2006-11-28 22:06 ` Andreas Dilger
2006-09-14 13:46 ` Peter Staubach
2006-09-14 13:56 ` Trond Myklebust
2006-09-14 14:06 ` Alexandre Ratchov
2006-12-14 1:24 ` Andreas Dilger
2006-12-14 1:52 ` J. Bruce Fields
2006-12-14 16:48 ` Trond Myklebust
2006-12-14 23:04 ` Andreas Dilger [this message]
2006-09-13 19:31 ` Andreas Dilger
2006-09-14 1:24 ` J. Bruce Fields
2006-09-14 13:21 ` Alexandre Ratchov
2006-09-14 21:01 ` Andreas Dilger
2006-09-15 10:19 ` Alexandre Ratchov
2006-09-15 16:18 ` Andreas Dilger
2006-11-29 18:54 ` [RFC] [patch 0/3] change attribute for ext4 Jean-Noel Cordenner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061214230455.GN5937@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=alexandre.ratchov@bull.net \
--cc=bfields@fieldses.org \
--cc=linux-ext4@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).