From: Andrew Morton <akpm@osdl.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] ext2: conditional removal of NFSD code
Date: Sat, 6 Jan 2007 12:16:11 -0800 [thread overview]
Message-ID: <20070106121611.34485a4c.akpm@osdl.org> (raw)
In-Reply-To: <20070106195830.GA6711@martell.zuzino.mipt.ru>
On Sat, 6 Jan 2007 22:58:31 +0300
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> --- a/fs/ext2/namei.c
> +++ b/fs/ext2/namei.c
> @@ -70,6 +70,7 @@ static struct dentry *ext2_lookup(struct
> return d_splice_alias(inode, dentry);
> }
>
> +#if defined(CONFIG_EXPORTFS) || defined(CONFIG_EXPORTFS_MODULE)
> struct dentry *ext2_get_parent(struct dentry *child)
hm. Officially, one module isn't supposed to know about the presence of
another one at compile-time. Someone might want to come along and later
configure and compile the nfsd module and then try to load it into a kernel
which wasn't compiled with nfsd enabled.
But given that both modules are in mainline I suspect that nobody would
really be doing that in practice, and in the case of nfsd it might not even
work.
next prev parent reply other threads:[~2007-01-06 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 19:58 [PATCH] ext2: conditional removal of NFSD code Alexey Dobriyan
2007-01-06 20:16 ` Andrew Morton [this message]
2007-01-06 21:15 ` Alexey Dobriyan
2007-01-06 21:25 ` Matthew Wilcox
2007-01-06 21:44 ` Alexey Dobriyan
2007-01-06 21:52 ` Al Viro
2007-01-06 21:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070106121611.34485a4c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adobriyan@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).