From: Andreas Dilger <adilger@clusterfs.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race
Date: Wed, 17 Jan 2007 15:43:04 -0700 [thread overview]
Message-ID: <20070117224304.GM5236@schatzie.adilger.int> (raw)
In-Reply-To: <45A7F384.3050303@redhat.com>
On Jan 12, 2007 14:45 -0600, Eric Sandeen wrote:
> p.s. ext3_inc_count and ext3_dec_count seem misnamed, have an unused
> arg, and are very infrequently called. I'll probably submit a patch
> to just put the single line of code into the caller, too.
I use those functions in the > 32000 subdirs patch to handle the case
where a directory overflows the i_nlinks counter and needs to be set
to have i_nlinks = 1.
Patch was posted previously, but rejected because there is a potential
for directory loss if the filesystem is mounted on an older kernel
(i_nlinks == 1, subdir is removed, directory is truncated). I need to
add an ROCOMPAT feature in order to handle this, but haven't gotten
around to doing it.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2007-01-17 22:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 20:45 [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race Eric Sandeen
2007-01-12 21:02 ` Alex Tomas
2007-01-12 21:14 ` Eric Sandeen
2007-01-12 21:25 ` Alex Tomas
2007-01-12 21:48 ` Eric Sandeen
2007-01-12 21:55 ` Alex Tomas
2007-01-12 22:01 ` Eric Sandeen
2007-01-12 22:07 ` Alex Tomas
2007-01-12 22:35 ` Eric Sandeen
2007-01-12 21:17 ` Alex Tomas
2007-01-12 21:24 ` Dave Kleikamp
2007-01-14 11:58 ` Dmitriy Monakhov
2007-01-14 15:42 ` Eric Sandeen
2007-01-17 22:43 ` Andreas Dilger [this message]
2007-01-17 22:47 ` Eric Sandeen
2007-01-18 10:43 ` Andreas Dilger
2007-01-18 15:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070117224304.GM5236@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).