linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@clusterfs.com>
To: Jim Garlick <garlick@llnl.gov>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [patch 2/2] e2fsprogs: user selectable dup block handling in fsck
Date: Wed, 31 Jan 2007 23:16:23 -0700	[thread overview]
Message-ID: <20070201061623.GU5404@schatzie.adilger.int> (raw)
In-Reply-To: <Pine.LNX.4.61.0701310822320.25489@webb>

On Jan 31, 2007  08:24 -0800, Jim Garlick wrote:
> @@ -67,7 +68,8 @@ static const char *prompt[] = {
>  	N_("Unlink"),		/* 17 */
>  	N_("Clear HTree index"),/* 18 */
>  	N_("Recreate"),		/* 19 */
> -	"",			/* 20 */
> +	N_("Unlink file for lost+found reconnect in pass 3"), /* 20 */
>
> +	/* Unlink file for lost+found reconnect in pass 3? */
> +	{ PR_1D_DISCONNECT_QUESTION,
> +	  "", PROMPT_DISCONNECT, 0 },

Why not use PROMPT_CONNECT ("Connect to lost+found") and then
make the question "File with shared blocks found"?

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

  reply	other threads:[~2007-02-01  6:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31 16:22 [patch 1/2] e2fsprogs: user selectable dup block handling in fsck Jim Garlick
2007-01-31 16:24 ` [patch 2/2] " Jim Garlick
2007-02-01  6:16   ` Andreas Dilger [this message]
2007-02-01  6:06 ` [patch 1/2] " Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201061623.GU5404@schatzie.adilger.int \
    --to=adilger@clusterfs.com \
    --cc=garlick@llnl.gov \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).