Re: [Resubmit][PATCH 5/5] Secure Deletion and Trash-Bin Support for Ext4

[Andreas Dilger <adilger@clusterfs.com>]

On Feb 01, 2007  12:41 -0800, Mingming Cao wrote:
> On Thu, 2007-02-01 at 19:32 +0000, Dave Kleikamp wrote:
> > > Unfortunately, we need some file system-specific code to access per-file
> > > secure deletion and per-file trash bit attributes.  These attributes are
> > > supported only by some file systems and in different ways.  
> 
> The check for fs specific attributes has to be underlying fs code.  But
> the code the handling the secure delete and trash bin (although now is
> only two functions being called) are identical for all fs, could be move
> to VFS layer.
> 
> > Yeah, I did see that.  I wonder adding some inode or file operation just
> > to query the existence of those attributes (or something more generic)
> > would be too ugly.
> 
> I gave a brief thought on that yesterday, it was not very pretty:)

Actually, the major filesystems (ext3, reiserfs, jfs, xfs) all use the
same lsattr/chattr ioctl as ext2 (EXT2_IOC_GETFLAGS).  Maybe this code
can just do an ioctl inside the kernel?

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.