From: Andreas Dilger <adilger@clusterfs.com>
To: "Brian D. Behlendorf" <behlendorf1@llnl.gov>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, wartens2@llnl.gov
Subject: Re: e2fsprogs coverity patch <cid-4.diff>
Date: Mon, 12 Feb 2007 12:25:30 -0700 [thread overview]
Message-ID: <20070212192530.GM6565@schatzie.adilger.int> (raw)
In-Reply-To: <200702100211.l1A2BZvu007411@igsi.llnl.gov>
On Feb 09, 2007 18:11 -0800, Brian D. Behlendorf wrote:
> This check is unnecessary since fs_type is guaranteed to be set earlier in the
> function.
I'm not positive this is the right fix. If we are creating a journal device,
we shouldn't be using the normal defaults based on the size of the journal
device because this will often be much smaller than the actual filesystem.
I'd argue that we set fs_type="journal" earlier when fs_type is being first
set, if INCOMPAT_JOURNAL_DEV is set.
> Index: e2fsprogs+chaos/misc/mke2fs.c
> ===================================================================
> --- e2fsprogs+chaos.orig/misc/mke2fs.c
> +++ e2fsprogs+chaos/misc/mke2fs.c
> @@ -1310,8 +1310,6 @@ static void PRS(int argc, char *argv[])
>
> if (fs_param.s_feature_incompat &
> EXT3_FEATURE_INCOMPAT_JOURNAL_DEV) {
> - if (!fs_type)
> - fs_type = "journal";
> reserved_ratio = 0;
> fs_param.s_feature_incompat = EXT3_FEATURE_INCOMPAT_JOURNAL_DEV;
> fs_param.s_feature_compat = 0;
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2007-02-12 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 2:11 e2fsprogs coverity patch <cid-4.diff> Brian D. Behlendorf
2007-02-12 19:25 ` Andreas Dilger [this message]
2007-03-19 12:32 ` e2fsprogs coverity patch <cid-04.diff> Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070212192530.GM6565@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=behlendorf1@llnl.gov \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wartens2@llnl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).