From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-ext4@vger.kernel.org
Cc: sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com
Subject: [PATCH -mm] ext4: use NULL for pointers
Date: Wed, 21 Mar 2007 19:25:43 -0700 [thread overview]
Message-ID: <20070321192543.e17e23cd.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Use NULL instead of 0 for pointers:
fs/ext4/writeback.c:874:24: warning: Using plain integer as NULL pointer
fs/ext4/writeback.c:1105:23: warning: Using plain integer as NULL pointer
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
fs/ext4/writeback.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1.orig/fs/ext4/writeback.c
+++ linux-2.6.21-rc4-mm1/fs/ext4/writeback.c
@@ -41,6 +41,7 @@
#include <linux/jbd.h>
#include <linux/ext4_fs_extents.h>
#include <linux/smp_lock.h>
+#include <linux/stddef.h>
#include <linux/highuid.h>
#include <linux/pagemap.h>
#include <linux/quotaops.h>
@@ -871,7 +872,7 @@ int ext4_wb_prepare_write(struct file *f
wb_debug("read block %u\n",
(unsigned) bhw->b_blocknr);
set_bh_page(bhw, page, 0);
- bhw->b_this_page = 0;
+ bhw->b_this_page = NULL;
bhw->b_size = 1 << inode->i_blkbits;
atomic_set(&bhw->b_count, 1);
ll_rw_block(READ, 1, &bhw);
@@ -1102,7 +1103,7 @@ int ext4_wb_block_truncate_page(handle_t
wb_debug("read block %u for part.trunc on %lu\n",
(unsigned) bhw->b_blocknr, page->index);
set_bh_page(bhw, page, 0);
- bhw->b_this_page = 0;
+ bhw->b_this_page = NULL;
bhw->b_size = 1 << inode->i_blkbits;
atomic_set(&bhw->b_count, 1);
ll_rw_block(READ, 1, &bhw);
reply other threads:[~2007-03-22 2:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321192543.e17e23cd.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).