From: Andreas Dilger <adilger@clusterfs.com>
To: Timo Sirainen <tss@iki.fi>
Cc: Guillaume Chazarain <guichaz@yahoo.fr>, linux-ext4@vger.kernel.org
Subject: Re: 2.6.20 ext3 rename() returns success but doesn't unlink the source
Date: Fri, 23 Mar 2007 17:45:16 -0600 [thread overview]
Message-ID: <20070323234516.GH5967@schatzie.adilger.int> (raw)
In-Reply-To: <1174691913.10004.71.camel@hurina>
On Mar 24, 2007 01:18 +0200, Timo Sirainen wrote:
> On Fri, 2007-03-23 at 23:24 +0100, Guillaume Chazarain wrote:
> > Timo Sirainen a écrit :
> >
> > > rename("/mnt/Maildir/.Trash/new/1174635781.P25986Q0M341350.hurina",
> > > "/mnt/Maildir/.Trash/cur/1174635781.P25986Q0M341350.hurina:2,");
> >
> > $ ls -li /mnt/Maildir/.Trash/new/1174635781.P25986Q0M341350.hurina /mnt/Maildir/.Trash/cur/1174635781.P25986Q0M341350.hurina:2,
> > 122481 -rw------- 2 1000 1000 3091 Mar 23 08:43 /mnt/Maildir/.Trash/cur/1174635781.P25986Q0M341350.hurina:2,
> > 122481 -rw------- 2 1000 1000 3091 Mar 23 08:43 /mnt/Maildir/.Trash/new/1174635781.P25986Q0M341350.hurina
> >
> > All your files in the list are hard linked.
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=fs/namei.c;h=ee60cc4d3453209723d6f70982e7083d7cb39477;hb=HEAD#l2447
> > seems to handle your case as you see it:
> > if (old_dentry->d_inode == new_dentry->d_inode)
> > return 0;
>
> Hmm. Oh. So this is this intentional? First I ever heard of it, and also
> goes against my logic. I'll go complain to man pages people then. This
> will make my error handling difficult..
Yes, it is a very counter-intuitive requirement in the POSIX spec. The
GNU user tools do what is expected (unlink the source file).
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
prev parent reply other threads:[~2007-03-23 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 17:15 2.6.20 ext3 rename() returns success but doesn't unlink the source Timo Sirainen
2007-03-23 22:24 ` Guillaume Chazarain
2007-03-23 23:18 ` Timo Sirainen
2007-03-23 23:45 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323234516.GH5967@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=guichaz@yahoo.fr \
--cc=linux-ext4@vger.kernel.org \
--cc=tss@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox