From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shaggy@austin.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Copy i_flags to ext3 inode flags on write (version 2)
Date: Mon, 23 Apr 2007 20:33:00 +0200 [thread overview]
Message-ID: <20070423183300.GA6029@duck.suse.cz> (raw)
In-Reply-To: <20070420005337.91beacfe.akpm@linux-foundation.org>
On Fri 20-04-07 00:53:37, Andrew Morton wrote:
> On Tue, 17 Apr 2007 12:38:55 +0200 Jan Kara <jack@suse.cz> wrote:
>
> > attached is a second version of a patch that stores inode flags such as
> > S_IMMUTABLE, S_APPEND, etc. from i_flags to EXT3_I(inode)->i_flags when
> > inode is written to disk. The same thing is done on GETFLAGS ioctl.
> > Quota code changes these flags on quota files (to make it harder for
> > sysadmin to screw himself) and these changes were not correctly
> > propagated into the filesystem (especially, lsattr did not show them and
> > users were wondering...). Andrew, could you please put the patch into your
> > queue? Thanks.
>
> umm, OK.
Thanks.
> What about ext2 and all the zillions of others?
Oh, yes... I'll send you patch for ext2, GFS2 and OCFS2. The only
filesystem, which is capable to store such flags and is not converted is
JFS - I was not able to find a suitable place for copying flags from VFS
inode to ondisk copy (giving CC to Shaggy)...
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
next prev parent reply other threads:[~2007-04-23 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 10:38 [PATCH] Copy i_flags to ext3 inode flags on write (version 2) Jan Kara
2007-04-20 7:53 ` Andrew Morton
2007-04-23 18:33 ` Jan Kara [this message]
2007-04-24 15:14 ` Dave Kleikamp
2007-04-24 15:35 ` Jan Kara
2007-04-24 15:44 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423183300.GA6029@duck.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).