From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sct@redhat.com, adilger@clusterfs.com, clameter@sgi.com
Subject: Re: [RFC/PATCH] ext3: remove inode constructor
Date: Fri, 4 May 2007 13:02:41 -0700 [thread overview]
Message-ID: <20070504130241.c436eb43.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705041311230.1455@sbz-30.cs.Helsinki.FI>
On Fri, 4 May 2007 13:14:35 +0300 (EEST)
Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> As explained by Christoph Lameter, ext3_alloc_inode() touches the same
> cache line as init_once() so we gain nothing from using slab
> constructors. The SLUB allocator will be more effective without it
> (free pointer can be placed inside the free'd object), so move inode
> initialization to ext3_alloc_inode completely.
I got 100% rejects against this because Christoph has already had
his paws all over the slab constructor code everywhere.
Was going to fix it up but then decided that we ought to make changes
like this to ext4 as well. Ideally beforehand, but simultaneously is
OK as long as it's simple enough.
btw, for a benchmark I'd suggest just a silly create-10000-files
tight loop rather than something more complex like postmark.
next prev parent reply other threads:[~2007-05-04 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 10:14 [RFC/PATCH] ext3: remove inode constructor Pekka J Enberg
2007-05-04 16:08 ` Christoph Lameter
2007-05-05 9:21 ` Pekka J Enberg
2007-05-04 20:02 ` Andrew Morton [this message]
2007-05-05 8:58 ` Pekka J Enberg
2007-05-05 9:02 ` Andrew Morton
2007-05-05 9:08 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070504130241.c436eb43.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger@clusterfs.com \
--cc=clameter@sgi.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).