linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: david@lang.hm
Cc: Frank van Maarseveen <frankvm@frankvm.com>,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: JBD: ext2online wants too many credits (744 > 256)
Date: Mon, 7 May 2007 11:50:21 -0400	[thread overview]
Message-ID: <20070507155021.GD17180@thunk.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705070744350.18013@asgard.lang.hm>

On Mon, May 07, 2007 at 07:46:38AM -0700, david@lang.hm wrote:
> On Mon, 7 May 2007, Theodore Tso wrote:
> 
> >We're going to have to rethink the defaults of the journal size as it
> >relates to on-line resizing, but there might not be a lot of great
> >answers here.  We'll also have to look at the on-line resizing code
> >and see if there's a way to break up the resize operation into smaller
> >transactions as a way of avoiding this problem --- but that would
> >still leave the user stuck with a pathetically small 4M journal on a
> >3G filesystem.
> 
> why not just allocate a new journal (something along the lines of convert 
> the ext3 to ext2 then back to ext3 would be the ugly, scripted way of 
> doing it)
> 
> or is the problem that you are trying to resize things without remounting 
> them (and therefor without flushing the journal)

Yes, I'm referring to the difficulties of getting this right when
doing online (mounted) resizing, as that was the context of the
original bug report.

Clearly the right thing for resize2fs to do when it's doing an
off-line resize is to just adjust the journal inode and make it
bigger.  I'll add that to my todo list, but of course, patches to do
that would be gratefully accepted...

						- Ted

  reply	other threads:[~2007-05-07 15:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070506222626.GA25632@janus>
2007-05-07  4:40 ` JBD: ext2online wants too many credits (744 > 256) Andrew Morton
2007-05-07 13:53   ` Frank van Maarseveen
2007-05-07 18:51   ` Andreas Dilger
2007-05-07 14:27 ` Theodore Tso
2007-05-07 14:46   ` david
2007-05-07 15:50     ` Theodore Tso [this message]
2007-05-07 21:06       ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070507155021.GD17180@thunk.org \
    --to=tytso@mit.edu \
    --cc=david@lang.hm \
    --cc=frankvm@frankvm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).