From: Theodore Tso <tytso@mit.edu>
To: Kalpak Shah <kalpak@clusterfs.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted
Date: Tue, 8 May 2007 01:07:52 -0400 [thread overview]
Message-ID: <20070508050751.GE10940@thunk.org> (raw)
In-Reply-To: <1176984336.3812.10.camel@garfield>
On Thu, Apr 19, 2007 at 05:35:36PM +0530, Kalpak Shah wrote:
> This patch removes a code snippet from check_ea_in_inode() in pass1
> which checks if the EA values in the inode are sorted or not. The
> comments in fs/ext*/xattr.c state that the EA values in the external
> EA block are sorted but those in the inode need not be sorted. I
> have also attached a test image which has unsorted EAs in the
> inodes. The current e2fsck wrongly clears the EAs in the inode.
Applied.
- Ted
prev parent reply other threads:[~2007-05-08 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 12:05 [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted Kalpak Shah
2007-04-20 12:38 ` Theodore Tso
2007-04-20 13:05 ` Kalpak Shah
2007-04-20 14:10 ` Theodore Tso
2007-04-20 19:17 ` Kalpak Shah
2007-05-08 5:07 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508050751.GE10940@thunk.org \
--to=tytso@mit.edu \
--cc=kalpak@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).